Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owWGg-0004de-JC for pgsql-hackers@arkaria.postgresql.org; Sat, 19 Nov 2022 22:24:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1owWGf-0006qL-IJ for pgsql-hackers@arkaria.postgresql.org; Sat, 19 Nov 2022 22:24:57 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owWGf-0006qC-9F for pgsql-hackers@lists.postgresql.org; Sat, 19 Nov 2022 22:24:57 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owWGd-0002ak-5B for pgsql-hackers@postgresql.org; Sat, 19 Nov 2022 22:24:56 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 2AJMOo6r2655403; Sat, 19 Nov 2022 17:24:51 -0500 From: Tom Lane To: Andres Freund cc: Joe Conway , Robert Haas , PostgreSQL-development Subject: Re: pgsql: Fix typos and bump catversion. In-reply-to: <20221119221618.ukkzaj3lilrrt52o@awork3.anarazel.de> References: <1e37f7d5-08a7-fbfb-da2e-b4aa5f409e01@joeconway.com> <20221119221618.ukkzaj3lilrrt52o@awork3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Sat, 19 Nov 2022 14:16:18 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2655401.1668896690.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sat, 19 Nov 2022 17:24:50 -0500 Message-ID: <2655402.1668896690@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > On 2022-11-19 17:10:57 -0500, Joe Conway wrote: >> Rishu Bagga pointed out to me offlist that this catversion bump seems >> flawed: >> /* yyyymmddN */ >> -#define CATALOG_VERSION_NO 202211121 >> +#define CATALOG_VERSION_NO 202211821 >> I think that should be 202211181, no? I am not clear on the desirable w= ay to >> fix though :-/ > I think it's fine to just update to a "normal" catversion. Yeah, just fix it --- and the sooner the better, to avoid the risk that this becomes a value that someone needs to care about. regards, tom lane