From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Laurenz Albe <laurenz.albe@cybertec.at>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Allow concurrent-safe open() and fopen() in frontend code
 for Wi
In-reply-to: <20180919023211.GC1650@paquier.xyz>
References: <19655.1537195712@sss.pgh.pa.us>
 <f62917d5-cc77-c6ac-847f-44f922ccdd97@2ndQuadrant.com>
 <3883.1537200836@sss.pgh.pa.us> <11148.1537227504@sss.pgh.pa.us>
 <20180918001143.GG31460@paquier.xyz> <20180918024227.GI31460@paquier.xyz>
 <23296.1537281909@sss.pgh.pa.us>
 <71bf47219037a5e3839748eb55e4fa175b58f523.camel@cybertec.at>
 <25361.1537285137@sss.pgh.pa.us>
 <c68010480459c79f24a015096ae43b6f0bcd9854.camel@cybertec.at>
 <20180919023211.GC1650@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Wed, 19 Sep 2018 11:32:11 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <26881.1537372501.1@sss.pgh.pa.us>
Date: Wed, 19 Sep 2018 11:55:01 -0400
Message-ID: <26882.1537372501@sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> I have spent a large portion of my morning trying to test all the
> solutions proposed, and a winner shows up.  ...

> - win32-open-laurenz.patch, which enforces to text mode only if binary
> mode is not defined, which maps strictly to what pre-11 is doing when
> calling the system _open or _fopen.  And surprisingly, this is proving
> to pass all the tests I ran: bincheck (including pgbench and pg_dump),
> upgradecheck, recoverycheck, check, etc.  initdb --pwfile is not
> complaining to me either.

I'm OK with this approach.  I wonder though what happens if you take
away the "#ifdef FRONTEND" and just enforce that one or the other mode
is selected always.  That would seem like a sensible solution rather
than a wart to me ...

			regards, tom lane