From: Tom Lane <tgl@sss.pgh.pa.us>
To: Christoph Berg <myon@debian.org>
cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: UCT (Re: pgsql: Update time zone data files to tzdata release
 2019a.)
In-reply-to: <20190614095546.GA15107@msg.df7cb.de>
References: <E1hK8qL-0005yH-VX@gemulon.postgresql.org>
 <20190604085735.GD24018@msg.df7cb.de> <65800.1559662051@sss.pgh.pa.us>
 <20190605084735.GC15829@msg.df7cb.de> <24452.1560285699@sss.pgh.pa.us>
 <20190614095546.GA15107@msg.df7cb.de>
Comments: In-reply-to Christoph Berg <myon@debian.org>
	message dated "Fri, 14 Jun 2019 11:55:46 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <26947.1560517875.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 14 Jun 2019 09:11:15 -0400
Message-ID: <26948.1560517875@sss.pgh.pa.us>
Precedence: bulk

Christoph Berg <myon@debian.org> writes:
> Re: Tom Lane 2019-06-11 <24452.1560285699@sss.pgh.pa.us>
>> The only way I can get it to pick "Etc/UCT" is if that's what I put
>> into /etc/localtime.  (In which case I maintain that that's not a bug,
>> or at least not our bug.)

> Did you try a symlink or a plain file for /etc/localtime?

Symlink --- if it's a plain file, our code can't learn anything from it.

> On Debian unstable, deleting /etc/timezone, $TZ not set, and with this s=
ymlink:
> lrwxrwxrwx 1 root root 27 M=C3=A4r 28 14:49 /etc/localtime -> /usr/share=
/zoneinfo/Etc/UTC

> /usr/lib/postgresql/11/bin/initdb -D pgdata
> $ grep timezone pgdata/postgresql.conf
> log_timezone =3D 'UCT'
> timezone =3D 'UCT'

> /usr/lib/postgresql/12/bin/initdb -D pgdata
> $ grep timezone pgdata/postgresql.conf
> log_timezone =3D 'Etc/UTC'
> timezone =3D 'Etc/UTC'

That's what I'd expect.  Do you think your upthread report of HEAD
picking "Etc/UCT" was a typo?  Or maybe you actually had /etc/localtime
set that way?

>> Anyway, moving on to the question of what should we do about this,
>> I don't really have anything better to offer than back-patching 23bd3ce=
c6.

> The PG12 behavior seems sane, so +1.

OK, I'll make that happen.

			regards, tom lane