Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nj3uo-0007v0-M7 for pgsql-hackers@arkaria.postgresql.org; Mon, 25 Apr 2022 18:58:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nj3to-0005ax-JW for pgsql-hackers@arkaria.postgresql.org; Mon, 25 Apr 2022 18:57:28 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nj3to-0005ao-8w for pgsql-hackers@lists.postgresql.org; Mon, 25 Apr 2022 18:57:28 +0000 Received: from relay8-d.mail.gandi.net ([2001:4b98:dc4:8::228]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nj3th-0007Et-2a for pgsql-hackers@lists.postgresql.org; Mon, 25 Apr 2022 18:57:26 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id 4AE451BF203; Mon, 25 Apr 2022 18:57:13 +0000 (UTC) Message-ID: <26dd4f55-318e-973e-a964-a7088dc06ee8@dunslane.net> Date: Mon, 25 Apr 2022 14:57:12 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: pgsql: Allow db.schema.table patterns, but complain about random garbag Content-Language: en-US From: Andrew Dunstan To: Noah Misch Cc: Robert Haas , Thomas Munro , Tom Lane , PostgreSQL Hackers References: <3a190754-b2b0-d02b-dcfd-4ec1610ffbcb@dunslane.net> <3687648.1650636245@sss.pgh.pa.us> <20220423025927.GA1274057@rfd.leadboat.com> <22c77d3c-3f90-2451-1f95-ed0d3e196d81@dunslane.net> <20220424181934.GA1326154@rfd.leadboat.com> <614341e3-3c12-e9a8-4b6d-ae2b3bc064cb@dunslane.net> In-Reply-To: <614341e3-3c12-e9a8-4b6d-ae2b3bc064cb@dunslane.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-04-24 Su 15:37, Andrew Dunstan wrote: > On 2022-04-24 Su 14:19, Noah Misch wrote: > >> Even if MinGW has >> some magic to make that work, I suspect we'll want a non-header home. Perhaps >> src/common/exec.c? It's best to keep this symbol out of libpq and other >> DLLs, though I bet exports.txt would avoid functional problems. > > exec.c looks like it should work fine. > > OK, in the absence of further comment I'm going to do it that way. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com