Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nX3Kr-0003sq-Rq for pgsql-committers@arkaria.postgresql.org; Wed, 23 Mar 2022 15:55:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nX3Kq-0004w8-Ma for pgsql-committers@arkaria.postgresql.org; Wed, 23 Mar 2022 15:55:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nX3Kq-0004t0-FV for pgsql-committers@lists.postgresql.org; Wed, 23 Mar 2022 15:55:44 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nX3Kn-0006Os-Ov; Wed, 23 Mar 2022 15:55:44 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 22NFtb2d2722836; Wed, 23 Mar 2022 11:55:37 -0400 From: Tom Lane To: Andres Freund cc: pgsql-committers@lists.postgresql.org, Robert Haas Subject: Re: pgsql: Unbreak the build. In-reply-to: References: Comments: In-reply-to Andres Freund message dated "Wed, 23 Mar 2022 07:58:18 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2722834.1648050937.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Wed, 23 Mar 2022 11:55:37 -0400 Message-ID: <2722835.1648050937@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > And windows still fails tests after this commit: https://cirrus-ci.com/t= ask/6424123323711488?logs=3Dtest_bin#L22 Yeah. drongo is reporting # Running: pg_basebackup --no-sync -cfast -D C:\\prog\\bf\\root\\HEAD\\pgs= ql.build\\src\\bin\\pg_basebackup\\tmp_check\\tmp_test_vv4i/tarbackup -Ft Assertion failed: 0, file c:\\prog\\bf\\root\\HEAD\\pgsql.build\\src\\bin\= \pg_basebackup\\walmethods.c, line 953 not ok 82 - tar format # Failed test 'tar format' # at t/010_pg_basebackup.pl line 261. which is pointing at /* not reachable */ Assert(false); so it's not so unreachable after all. regards, tom lane