From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
cc: Andres Freund <andres@anarazel.de>,
        pgsql-committers <pgsql-committers@postgresql.org>
Subject: Re: pgsql: Add support for coordinating record typmods among parallel
 worke
In-reply-to: 
 <CAEepm=0y78KA-UFVA=q8joA4m9tPre5y7VxMy2Jzigo+O6E6MA@mail.gmail.com>
References: <E1dsguX-00056N-9x@gemulon.postgresql.org>
 <13971.1505445491@sss.pgh.pa.us>
 <CAEepm=08r6ssWnM7wOAN=omz=s9DHujsJjJY6SN_PTHayPR0hw@mail.gmail.com>
 <14932.1505447120@sss.pgh.pa.us>
 <CAEepm=13KfNVsjzvdz_u4E_3_joAWfL+k6TNaFkr-=WTT_Ou=A@mail.gmail.com>
 <CAEepm=2q2OoJ5K1Mg2_XaqjSSRbMTAmE4V7fsM5O3yTWWkb2aw@mail.gmail.com>
 <29888.1505451575@sss.pgh.pa.us>
 <CAEepm=0y78KA-UFVA=q8joA4m9tPre5y7VxMy2Jzigo+O6E6MA@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@enterprisedb.com>
	message dated "Fri, 15 Sep 2017 18:47:10 +1200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2727.1505487317.1@sss.pgh.pa.us>
Date: Fri, 15 Sep 2017 10:55:17 -0400
Message-ID: <2728.1505487317@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-committers-owner@postgresql.org

Thomas Munro <thomas.munro@enterprisedb.com> writes:
> The attached patch fixes the problem
> by getting rid of the code that accesses shmem in the detach hook.
> With this patch applied installcheck survives on a cluster with
> force_parallel_worker=regress.

In hopes of getting the buildfarm back to green, I went ahead and pushed
a slightly more aggressive form of this --- I took out the worker-specific
detach function altogether.  We can resurrect it if we ever have a more
plausible idea of how to do worker recycling, but for now I don't see a
reason to waste bytes on useless and incorrect code.

			regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers