From: Tom Lane <tgl@sss.pgh.pa.us>
To: ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=)
cc: Christoph Berg <myon@debian.org>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
In-reply-to: <87o8vk1n2u.fsf@wibble.ilmari.org>
References: <E1in6ft-0004zR-6l@gemulon.postgresql.org>
 <20200103110128.GA28967@msg.df7cb.de> <14261.1578060227@sss.pgh.pa.us>
 <87o8vk1n2u.fsf@wibble.ilmari.org>
Comments: In-reply-to ilmari@ilmari.org (Dagfinn Ilmari
 =?utf-8?Q?Manns=C3=A5ker?=)
	message dated "Fri, 03 Jan 2020 17:12:09 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <27519.1578074123.1@sss.pgh.pa.us>
Date: Fri, 03 Jan 2020 12:55:23 -0500
Message-ID: <27520.1578074123@sss.pgh.pa.us>
Precedence: bulk

ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes:
> Tom Lane <tgl@sss.pgh.pa.us> writes:
>> Anybody know an easy way to do that in Perl?

> I was going to suggest using Test::More's like() function to do the
> regex check, but sadly that only escapes things that would break the TAP
> stream syntax, not non-printables in general.  The next obvious thing is
> Data::Dumper with the 'Useqq' option enabled, which makes it use
> double-quoted-string escapes (e.g. "\a" for ^G).

> The attaced patch does that, and also bumps $Test::Builder::Level so the
> diagnostic references the calling line, and uses diag() instad of
> note(), so it shows even in non-verbose mode.

LGTM, pushed (along with a fix to deal with what hopefully is the
only remaining obstacle for Andres' critters).

			regards, tom lane