From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: Alvaro Herrera <alvherre@2ndquadrant.com>, pgsql-hackers@postgresql.org
Subject: Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent
 run.
In-reply-to: <3445db65-94ac-73ab-760a-7ad84d9ef54a@2ndquadrant.com>
References: <20170517140847.lasiafwmsxgzppm6@alvherre.pgsql>
 <30659.1495030469@sss.pgh.pa.us> <31076.1495031000@sss.pgh.pa.us>
 <9404.1495035429@sss.pgh.pa.us>
 <3445db65-94ac-73ab-760a-7ad84d9ef54a@2ndquadrant.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
	message dated "Wed, 17 May 2017 11:52:10 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <27594.1495039103.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 17 May 2017 12:38:23 -0400
Message-ID: <27595.1495039103@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 5/17/17 11:37, Tom Lane wrote:
>> Concretely, how about the attached?  I don't think this looks any
>> worse than the current layout.

> The previous setup has been in place for years and has never been a
> problem.  The alternatives are all quite a bit worse.

No, the previous setup hasn't been "in place for years".  These programs
were only NLS-ified last fall.  Before that the code looked like, eg,

	printf("  -z, --stats[=3Drecord]   show statistics instead of records\n");
	printf("                         (optionally, show per-record statistics)\=
n");

so that there weren't string continuations for pgindent to fool with.

I'm not really convinced that having usage() print two- or three-line
switch descriptions is "quite a bit better" than what I suggested.

			regards, tom lane


--=20
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers