From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <tmunro@postgresql.org>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Check for STATUS_DELETE_PENDING on Windows.
In-reply-to: <E1mvWTz-0006Hc-Dn@gemulon.postgresql.org>
References: <E1mvWTz-0006Hc-Dn@gemulon.postgresql.org>
Comments: In-reply-to Thomas Munro <tmunro@postgresql.org>
	message dated "Fri, 10 Dec 2021 03:22:03 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2760527.1641929756.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 11 Jan 2022 14:35:56 -0500
Message-ID: <2760528.1641929756@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2760528.1641929756%40sss.pgh.pa.us>
Precedence: bulk

Thomas Munro <tmunro@postgresql.org> writes:
> Check for STATUS_DELETE_PENDING on Windows.

The src/include/port/win32ntdll.h file added by this commit has
a couple of deficiencies:

1. It lacks the usual anti-multiple-inclusion guard, i.e.
	#ifndef WIN32NTDLL_H
or the like.  Was there a specific reason to omit that?

2. headerscheck and cpluspluscheck don't like it, at least
not on non-Windows:

$ src/tools/pginclude/headerscheck =

In file included from /tmp/headerscheck.WKh8cz/test.c:2:
./src/include/port/win32ntdll.h:20:10: fatal error: ntstatus.h: No such fi=
le or directory
 #include <ntstatus.h>
          ^~~~~~~~~~~~

One way to solve that, perhaps, is to wrap the whole header
in #ifdef WIN32.  But I think our more usual practice has
been to add such headers to the exclusion lists in those
two scripts.

			regards, tom lane