Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dB1z6-0004mo-ID for pgsql-hackers@arkaria.postgresql.org; Wed, 17 May 2017 16:39:36 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dB1z6-0006VF-0e for pgsql-hackers@arkaria.postgresql.org; Wed, 17 May 2017 16:39:36 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dB1z5-0006TA-75 for pgsql-hackers@postgresql.org; Wed, 17 May 2017 16:39:35 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dB1z2-00067T-6l for pgsql-hackers@postgresql.org; Wed, 17 May 2017 16:39:34 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v4HGdUg7027645; Wed, 17 May 2017 12:39:30 -0400 From: Tom Lane To: Peter Eisentraut cc: Alvaro Herrera , pgsql-hackers@postgresql.org Subject: Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run. In-reply-to: References: <20170517140847.lasiafwmsxgzppm6@alvherre.pgsql> <30659.1495030469@sss.pgh.pa.us> Comments: In-reply-to Peter Eisentraut message dated "Wed, 17 May 2017 11:55:11 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <27643.1495039170.1@sss.pgh.pa.us> Date: Wed, 17 May 2017 12:39:30 -0400 Message-ID: <27644.1495039170@sss.pgh.pa.us> X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Peter Eisentraut writes: > On 5/17/17 10:14, Tom Lane wrote: >> What I was concerned about was that pgindent will reindent the second >> line so that it's impossible to tell whether the spacing is correct. > pgindent moving string continuations to the left is a completely > terrible behavior anyway and we should look into changing that. Just > look at the mess it makes out of SELECT queries in pg_dump.c. I'd be on board with that, perhaps, but does anyone here have enough insight into bsd_indent to fix that without breaking other stuff? regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers