Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1to4Zj-005dDv-Io
	for pgsql-committers@arkaria.postgresql.org; Fri, 28 Feb 2025 17:55:04 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1to4Zk-00Bsc6-Lo
	for pgsql-committers@arkaria.postgresql.org; Fri, 28 Feb 2025 17:55:03 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1to4Zk-00Bsbx-EL
	for pgsql-committers@lists.postgresql.org; Fri, 28 Feb 2025 17:55:03 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1to4Zf-000DLi-1k;
	Fri, 28 Feb 2025 17:55:02 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 51SHsvYH2768650;
	Fri, 28 Feb 2025 12:54:57 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Sami Imseih <samimseih@gmail.com>
cc: Andrew Dunstan <andrew@dunslane.net>, Jeff Davis <pgsql@j-davis.com>,
        Jeff Davis <jdavis@postgresql.org>,
        pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Trial fix for old cross-version upgrades.
In-reply-to: 
 <CAA5RZ0u9dV3CdKqkqdusA_RdvBkwWe0c0rxcFWj++VYoutFYSw@mail.gmail.com>
References: <E1tlBJt-000LUO-16@gemulon.postgresql.org>
 <003dc9936317ab987faa0242f8e33e1cd2fcaf57.camel@j-davis.com>
 <40c1e76334f2baa747334c8fc513d12b8cb297bf.camel@j-davis.com>
 <3815127.1740189601@sss.pgh.pa.us>
 <5ebc188e731ac2b98d68459ce1a9ef3066981774.camel@j-davis.com>
 <3892121.1740193866@sss.pgh.pa.us>
 <976dcc37-b629-490e-a052-a057477d062f@dunslane.net>
 <301492.1740249291@sss.pgh.pa.us> <684274.1740273302@sss.pgh.pa.us>
 <812817.1740277228@sss.pgh.pa.us>
 <10bd5e38-c8e1-4162-8dd7-ef65e71170b4@dunslane.net>
 <1144186.1740338230@sss.pgh.pa.us>
 <CAA5RZ0u9dV3CdKqkqdusA_RdvBkwWe0c0rxcFWj++VYoutFYSw@mail.gmail.com>
Comments: In-reply-to Sami Imseih <samimseih@gmail.com>
	message dated "Fri, 28 Feb 2025 11:12:41 -0600"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2768648.1740765297.1@sss.pgh.pa.us>
Date: Fri, 28 Feb 2025 12:54:57 -0500
Message-ID: <2768649.1740765297@sss.pgh.pa.us>
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Archived-At: 
 <https://www.postgresql.org/message-id/2768649.1740765297%40sss.pgh.pa.us>
Precedence: bulk

Sami Imseih <samimseih@gmail.com> writes:
> I was running "make check-world" this morning on a machine that has an
> old version of perl, 5.16, and the check-world was hung on
> /usr/bin/perl t/002_pg_upgrade.pl.

Interesting!

> and specifically, the process hangs with this specific change.

> -       $dump =~ s ['version', '\d+'::integer,]
> -               ['version', '000000'::integer,]mg;
> +       $dump =~ s {(^\s+'version',) '\d+'::integer,$}
> +               {$1 '000000'::integer,}mg;

5.16 is still supported according to our install instructions,
so let's see if we can adjust that regex so it works with 5.16.
The first thing I'd try is

-       $dump =~ s {(^\s+'version',) '\d+'::integer,$}
+       $dump =~ s {^(\s+'version',) '\d+'::integer,$}

since I notice we mostly don't put ^ inside capture parens elsewhere.
Are you in a position to test that?

			regards, tom lane