Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M311873=pgsql-hackers-arkari@postgresql.org>)
	id 1cE69h-0002BF-Na
	for pgsql-hackers@arkaria.postgresql.org; Tue, 06 Dec 2016 03:10:57 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
	by malur.postgresql.org with smtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M311873=pgsql-hackers-arkari@postgresql.org>)
	id 1cE69g-0002gk-J9
	for pgsql-hackers@arkaria.postgresql.org; Tue, 06 Dec 2016 03:10:56 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1cE69f-0002fq-9Y
	for pgsql-hackers@postgreSQL.org; Tue, 06 Dec 2016 03:10:55 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1cE69Y-0005zv-KE
	for pgsql-hackers@postgreSQL.org; Tue, 06 Dec 2016 03:10:54 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id uB63AknL027738;
	Mon, 5 Dec 2016 22:10:46 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: pgsql-hackers@postgreSQL.org
Subject: Re: [COMMITTERS] pgsql: Permit dump/reload of not-too-large >1GB
 tuples
In-reply-to: <E1cCf6H-0002Y6-F5@gemulon.postgresql.org>
References: <E1cCf6H-0002Y6-F5@gemulon.postgresql.org>
Comments: In-reply-to Alvaro Herrera <alvherre@alvh.no-ip.org>
	message dated "Fri, 02 Dec 2016 04:05:29 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <27736.1480993846.1@sss.pgh.pa.us>
Date: Mon, 05 Dec 2016 22:10:46 -0500
Message-ID: <27737.1480993846@sss.pgh.pa.us>
X-Pg-Spam-Score: -4.9 (----)
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Permit dump/reload of not-too-large >1GB tuples

I apologize for not having paid close enough attention earlier, but:
this patch is absolutely unacceptable for the back branches and MUST
be reverted there.  Adding another field to StringInfoData is an ABI
change that will certainly break large numbers of extensions.  We
can't expect those to get recompiled for minor releases.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers