Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1a2keR-0001hd-Pf for pgsql-committers@arkaria.postgresql.org; Sat, 28 Nov 2015 18:55:15 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1a2keR-0003H6-6s for pgsql-committers@arkaria.postgresql.org; Sat, 28 Nov 2015 18:55:15 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1a2keP-0003Fh-Es for pgsql-committers@postgresql.org; Sat, 28 Nov 2015 18:55:13 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1a2keM-0000vB-Lo; Sat, 28 Nov 2015 18:55:12 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id tASIt9RF027772; Sat, 28 Nov 2015 13:55:09 -0500 From: Tom Lane To: Tatsuo Ishii cc: pgsql-committers@postgresql.org Subject: Re: pgsql: Fix broken multibyte regression tests. In-reply-to: References: Comments: In-reply-to Tatsuo Ishii message dated "Sun, 09 Aug 2015 02:09:25 -0000" Date: Sat, 28 Nov 2015 13:55:09 -0500 Message-ID: <27771.1448736909@sss.pgh.pa.us> X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-committers Precedence: bulk Sender: pgsql-committers-owner@postgresql.org Tatsuo Ishii writes: > Fix broken multibyte regression tests. > commit 9043Fe390f4f0b4586cfe59cbd22314b9c3e2957 broke multibyte > regression tests because the commit removes the warning message when > temporary hash indexes is created, which has been added by commit > 07af523870bcfe930134054febd3a6a114942e5b. > Back patched to 9.5 stable tree. AFAICT this patch was incorrect and should be reverted, because the src/test/mb tests all fail for me, in both HEAD and 9.5, as a consequence of getting hash-index WARNINGs that are not in the expected-files. The commit you mention (which is 9043ef390f4f0b4586cfe59cbd22314b9c3e2957 not what's cited in this commit message) disabled the WARNING for temporary and unlogged hash indexes, but the indexes created by the test scripts are neither. Please recheck it. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers