From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter_e@gmx.net>
cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Add support for temporary replication slots
In-reply-to: <27274.1481557380@sss.pgh.pa.us>
References: <E1cGRP8-0003EH-So@gemulon.postgresql.org>
 <27274.1481557380@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Mon, 12 Dec 2016 10:43:00 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <27832.1481558144.1@sss.pgh.pa.us>
Date: Mon, 12 Dec 2016 10:55:44 -0500
Message-ID: <27833.1481558144@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-committers-owner@postgresql.org

I wrote:
> Peter Eisentraut <peter_e@gmx.net> writes:
>> Add support for temporary replication slots

> Some of the slower buildfarm members are failing test-decoding-check since
> this went in.  At least on prairiedog, it looks like a race condition in
> the test:

Having now looked a bit more closely, that's almost certainly what it is:
the test is assuming that the old backend exits instantaneously, which
it doesn't.  You might want to borrow the wait-for-previous-session-to-die
loop I put into src/test/modules/test_extensions/sql/test_extensions.sql
recently.  (Make sure you get the fixed version ;-))

			regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers