Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mCRkZ-0000dp-O6 for pgsql-committers@arkaria.postgresql.org; Sat, 07 Aug 2021 19:12:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mCRkW-0004aV-Jw for pgsql-committers@arkaria.postgresql.org; Sat, 07 Aug 2021 19:12:48 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mCRkW-0004aN-DA for pgsql-committers@lists.postgresql.org; Sat, 07 Aug 2021 19:12:48 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mCRkU-0001DK-2a for pgsql-committers@lists.postgresql.org; Sat, 07 Aug 2021 19:12:47 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 177JCcVj2788097; Sat, 7 Aug 2021 15:12:39 -0400 From: Tom Lane To: Andres Freund cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: pgstat: Bring up pgstat in BaseInit() to fix uninitialized use o In-reply-to: <20210807185141.ncmuxchr6d2qv2v6@alap3.anarazel.de> References: <20210807030652.qf5wsbhxk7dpsmtn@alap3.anarazel.de> <2640064.1628306008@sss.pgh.pa.us> <2640490.1628306556@sss.pgh.pa.us> <20210807044952.orwuf7hua2wytx4g@alap3.anarazel.de> <20210807051149.x2j3n64ejcu23hm4@alap3.anarazel.de> <2675112.1628350987@sss.pgh.pa.us> <20210807164850.52atvo2qkmtfnzgt@alap3.anarazel.de> <2771326.1628356007@sss.pgh.pa.us> <20210807172556.rda5m7jjhk7ktukl@alap3.anarazel.de> <2782786.1628357836@sss.pgh.pa.us> <20210807185141.ncmuxchr6d2qv2v6@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Sat, 07 Aug 2021 11:51:41 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2788095.1628363558.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sat, 07 Aug 2021 15:12:38 -0400 Message-ID: <2788096.1628363558@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > On 2021-08-07 13:37:16 -0400, Tom Lane wrote: >> Depends what you want to define as a bug. What I am not happy about >> is the prospect of random assertion failures for the next six months >> while you finish redesigning half of the system. The rest of us >> have work we want to get done, too. I don't object to the idea of >> making no-lost-events an end goal, but we are clearly not ready >> for that today. > I don't know what to do about that. How would we even find these cases i= f they > aren't hit during regression tests on my machine (nor on a lot of others= )? The regression tests really aren't that helpful for testing the problem scenario here, which basically is SIGTERM'ing a query-in-progress. I'm rather surprised that the buildfarm managed to exercise that at all. You might try setting up a test scaffold that runs the core regression tests and SIGINT's the postmaster, or alternatively SIGTERM's some individual session, at random times partway through. Obviously this will make the regression tests report failure, but what to look for is if anything dumps core on the way out. regards, tom lane