Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJncz-0001gq-0O for pgsql-committers@arkaria.postgresql.org; Thu, 13 Jul 2023 04:08:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qJncx-0007uK-SS for pgsql-committers@arkaria.postgresql.org; Thu, 13 Jul 2023 04:08:27 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJncx-0007u5-LM for pgsql-committers@lists.postgresql.org; Thu, 13 Jul 2023 04:08:27 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qJncq-0007Wl-Cl; Thu, 13 Jul 2023 04:08:26 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 36D48KRT2795365; Thu, 13 Jul 2023 00:08:20 -0400 From: Tom Lane To: Amit Langote cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Pass constructName to transformJsonValueExpr() In-reply-to: References: Comments: In-reply-to Amit Langote message dated "Thu, 13 Jul 2023 03:33:07 -0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2795363.1689221300.1@sss.pgh.pa.us> Date: Thu, 13 Jul 2023 00:08:20 -0400 Message-ID: <2795364.1689221300@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Amit Langote writes: > Pass constructName to transformJsonValueExpr() Surely "char *constructName" should be "const char *constructName"? regards, tom lane