Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZdrJ-0004UK-8O for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Mar 2022 19:19:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nZdrI-00014O-67 for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Mar 2022 19:19:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZdrH-00014C-TS for pgsql-hackers@lists.postgresql.org; Wed, 30 Mar 2022 19:19:55 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZdrF-0004IJ-U5 for pgsql-hackers@lists.postgresql.org; Wed, 30 Mar 2022 19:19:55 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 22UJJmtn279982; Wed, 30 Mar 2022 15:19:48 -0400 From: Tom Lane To: Andres Freund cc: Robert Haas , Andrew Dunstan , PostgreSQL Hackers , Magnus Hagander Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module. In-reply-to: <20220330191251.sgxjox64k3eteylb@alap3.anarazel.de> References: <20220326193528.rabb66n6i7ghhesx@alap3.anarazel.de> <144620.1648326272@sss.pgh.pa.us> <20220326205135.e47br5qj7urgqoqy@alap3.anarazel.de> <20220330162311.uxaxpt2e46c3q6lk@alap3.anarazel.de> <228044.1648658074@sss.pgh.pa.us> <20220330165039.3zseuiraxfjkksf5@alap3.anarazel.de> <230838.1648659506@sss.pgh.pa.us> <20220330191251.sgxjox64k3eteylb@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Wed, 30 Mar 2022 12:12:51 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <279980.1648667988.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Wed, 30 Mar 2022 15:19:48 -0400 Message-ID: <279981.1648667988@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > On 2022-03-30 13:16:47 -0400, Robert Haas wrote: >> On Wed, Mar 30, 2022 at 1:11 PM Andres Freund wrot= e: >>> My concern is about the quote in the middle of the path, not about quo= ting at all... I.e. the ' should be after /tmp_install, not before. >> Makes no difference. We know that the string /tmp_install contains no >> shell metacharacters, so why does it need to be in quotes? I would've >> probably written it the way it is here, rather than what you are >> proposing. > It looks ugly, and it can't be copy-pasted as easily. Seems I'm alone on= this, > so I'll leave it be... FWIW, I agree with Andres that I'd probably have put the quote at the end. But Robert is right that it's functionally equivalent; so I doubt it's worth changing. regards, tom lane