Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pz0Zh-0005lr-Dk for pgsql-committers@arkaria.postgresql.org; Tue, 16 May 2023 19:43:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pz0Zg-00048f-53 for pgsql-committers@arkaria.postgresql.org; Tue, 16 May 2023 19:43:08 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pz0Zf-00048W-TG for pgsql-committers@lists.postgresql.org; Tue, 16 May 2023 19:43:07 +0000 Received: from meldrar.postgresql.org ([2a02:c0:301:0:ffff::31]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pz0Zd-000BDv-AS for pgsql-committers@lists.postgresql.org; Tue, 16 May 2023 19:43:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=postgresql.org; s=20171124; h=To:References:Message-Id: Content-Transfer-Encoding:Cc:Date:In-Reply-To:From:Subject:Mime-Version: Content-Type:Sender:Reply-To:Content-ID:Content-Description; bh=HayKZqGGhivQ1FgoKAogMmb48Z+LmbkouciSabQcEXg=; b=kZPTDNhmRMjZ6Nx2f6hoM0dEMD HC/tSa3dmmem8DMXBb+qBsnhl+us7tuP5AbL9Nb1nP30DLC9umtaZBT2Y5Bbjs7wSZ6nT6//zomrD EQ9X4nqrMbKIun2E2s5ZWkIks/B+nGl2ozde4PIEIbRNphtl0YwxIvcNc9SgdPtcT9I0CIXBLNWYz wQWE+9AZ1dCJPM8TjpyXz6y8RnVaqQ0xcv5gPuc9WA6Zw3UGGcyqW9WQr0XF9/zCG99l3pj5sIvJs VFjPhHi6DfjVrMy99ZYoO1pgHnyWRbpPLHbKy7zZrgaWULVswrJPwmsplHlI4tcRubAjxTrFjBqHr vivtLuKA==; Received: from customer-89-255-232-193.stosn.net ([89.255.232.193] helo=smtpclient.apple) by meldrar.postgresql.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pz0ZZ-000QKm-B8; Tue, 16 May 2023 19:43:03 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.3\)) Subject: Re: pgsql: Refactor background psql TAP functions From: Daniel Gustafsson In-Reply-To: Date: Tue, 16 May 2023 21:43:00 +0200 Cc: Peter Eisentraut , pgsql-committers@lists.postgresql.org Content-Transfer-Encoding: quoted-printable Message-Id: <27BE2429-774C-46E6-8B0E-C024B83EC3B5@postgresql.org> References: <34800305-E1E6-4194-8738-9977946DB12A@postgresql.org> To: Damir Belyalov X-Mailer: Apple Mail (2.3696.120.41.1.3) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 16 May 2023, at 21:04, Damir Belyalov wrote: > There is another perl module: AdjustUpgrade.pm that is not in = Makefile. Do we need it? Yes, I think it should be installed too and skimming the linked thread I = see no mention of the omission being deliberate. I will take care of it. > + $(INSTALL_DATA) $(srcdir)/PostgreSQL/Test/BackgroundPsql.pm = '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/AdjustUpgrade.pm' This is wrong though, but no need to send a new version of this small = thing. -- Daniel Gustafsson