Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h7BnK-0006BD-7o for pgsql-committers@arkaria.postgresql.org; Fri, 22 Mar 2019 04:28:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1h7BnI-0004eW-Sq for pgsql-committers@arkaria.postgresql.org; Fri, 22 Mar 2019 04:28:36 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h7BnH-0004eL-Rg for pgsql-committers@lists.postgresql.org; Fri, 22 Mar 2019 04:28:35 +0000 Received: from tama500.ecl.ntt.co.jp ([129.60.39.148]) by makus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1h7BnE-0001Rf-NW for pgsql-committers@lists.postgresql.org; Fri, 22 Mar 2019 04:28:34 +0000 Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154]) by tama500.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id x2M4STnT032322; Fri, 22 Mar 2019 13:28:29 +0900 Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id B0C72638CA8; Fri, 22 Mar 2019 13:28:29 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id A5393638C13; Fri, 22 Mar 2019 13:28:29 +0900 (JST) Received: from [127.0.0.1] (unknown [129.60.241.61]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 9B3C0400ACC; Fri, 22 Mar 2019 13:28:29 +0900 (JST) Subject: Re: pgsql: Add pg_partition_root to display top-most parent of a partition References: <20190322032612.GA323@alvherre.pgsql> <20190322035538.GO20192@paquier.xyz> <06be11a6-fd8d-b68b-1b97-1bafb1d3185c@lab.ntt.co.jp> <20190322041225.GS20192@paquier.xyz> From: Amit Langote Message-ID: <27e4501a-ae56-94e4-1524-d509f048d61c@lab.ntt.co.jp> Date: Fri, 22 Mar 2019 13:28:19 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 In-Reply-To: <20190322041225.GS20192@paquier.xyz> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: Michael Paquier Cc: Alvaro Herrera , pgsql-committers@lists.postgresql.org X-TM-AS-MML: disable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019/03/22 13:12, Michael Paquier wrote: > On Fri, Mar 22, 2019 at 01:09:23PM +0900, Amit Langote wrote: >> /* Fetch the top-most parent */ >> ancestors = get_partition_ancestors(relid); >> >> Maybe, the patch should update this comment to say "Fetch the list of >> ancestors". > > Perhaps so. Note that actually the list is fetched to grab the > top-most parent from it, so it sort of makes sense? It looked fine before, but the new lines added by patch makes it look wrong/misplaced somehow. Thanks, Amit