Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkXSF-0002N9-0Y for pgsql-committers@arkaria.postgresql.org; Thu, 06 Apr 2023 21:47:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pkXSD-0004zL-TP for pgsql-committers@arkaria.postgresql.org; Thu, 06 Apr 2023 21:47:37 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkXSD-0004yI-L8 for pgsql-committers@lists.postgresql.org; Thu, 06 Apr 2023 21:47:37 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkXSB-0005IV-Es for pgsql-committers@lists.postgresql.org; Thu, 06 Apr 2023 21:47:36 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 336LlWm92800994; Thu, 6 Apr 2023 17:47:32 -0400 From: Tom Lane To: Andres Freund cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Fix ts_headline() edge cases for empty query and empty search te In-reply-to: <20230406213813.uep7plg6lvcywujo@awork3.anarazel.de> References: <20230406213813.uep7plg6lvcywujo@awork3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Thu, 06 Apr 2023 14:38:13 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2800992.1680817652.1@sss.pgh.pa.us> Date: Thu, 06 Apr 2023 17:47:32 -0400 Message-ID: <2800993.1680817652@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > On 2023-04-06 19:52:55 +0000, Tom Lane wrote: >> Fix ts_headline() edge cases for empty query and empty search text. > Unfortunately there appears to be some portability issue with this. Causes a > test output difference on macos. Huh ... looking. regards, tom lane