Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7P5w-0000l1-CQ for pgsql-committers@arkaria.postgresql.org; Tue, 11 Jan 2022 21:54:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1n7P5v-0002j4-71 for pgsql-committers@arkaria.postgresql.org; Tue, 11 Jan 2022 21:54:19 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7P5v-0002iu-0A for pgsql-committers@lists.postgresql.org; Tue, 11 Jan 2022 21:54:19 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7P5o-0002t5-Il; Tue, 11 Jan 2022 21:54:17 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 20BLsAk22801181; Tue, 11 Jan 2022 16:54:10 -0500 From: Tom Lane To: Andrew Dunstan cc: Thomas Munro , Thomas Munro , pgsql-committers Subject: Re: pgsql: Check for STATUS_DELETE_PENDING on Windows. In-reply-to: <8320cca6-5647-be5d-9b22-914415bcbc27@dunslane.net> References: <2760528.1641929756@sss.pgh.pa.us> <8320cca6-5647-be5d-9b22-914415bcbc27@dunslane.net> Comments: In-reply-to Andrew Dunstan message dated "Tue, 11 Jan 2022 16:44:15 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2801179.1641938050.1@sss.pgh.pa.us> Date: Tue, 11 Jan 2022 16:54:10 -0500 Message-ID: <2801180.1641938050@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andrew Dunstan writes: > On 1/11/22 16:22, Thomas Munro wrote: >> Those scripts aren't really on my radar... would it be a good idea to >> run them as steps in the CompilerWarnings CI task? > Or in a buildfarm module (c.f. the perl checks) +1 for one or the other, because we break that regularly and it typically takes awhile to notice. regards, tom lane