Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1sYU7u-00BhDF-TE
	for pgsql-hackers@arkaria.postgresql.org; Mon, 29 Jul 2024 17:25:38 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1sYU7t-001dpJ-Cw
	for pgsql-hackers@arkaria.postgresql.org; Mon, 29 Jul 2024 17:25:37 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1sYU7t-001dpA-3b
	for pgsql-hackers@lists.postgresql.org; Mon, 29 Jul 2024 17:25:37 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1sYU7q-0026Vl-U1
	for pgsql-hackers@postgresql.org; Mon, 29 Jul 2024 17:25:36 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 46THPMU12809050;
	Mon, 29 Jul 2024 13:25:22 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Heikki Linnakangas <hlinnaka@iki.fi>
cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org
Subject: Re: Detect double-release of spinlock
In-reply-to: <e8d4ef94-b8aa-4cda-8f31-081f78194275@iki.fi>
References: <E1sYSF2-001lEB-D1@gemulon.postgresql.org>
 <2600757.1722267116@sss.pgh.pa.us>
 <20240729161846.kgiafbe2dtgabxgb@awork3.anarazel.de>
 <2802449.1722270793@sss.pgh.pa.us>
 <20240729164026.yurg37tej34o76uk@awork3.anarazel.de>
 <20240729165154.56zqyg34x2ywkpsh@awork3.anarazel.de>
 <e8d4ef94-b8aa-4cda-8f31-081f78194275@iki.fi>
Comments: In-reply-to Heikki Linnakangas <hlinnaka@iki.fi>
	message dated "Mon, 29 Jul 2024 20:07:56 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2809048.1722273922.1@sss.pgh.pa.us>
Date: Mon, 29 Jul 2024 13:25:22 -0400
Message-ID: <2809049.1722273922@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/2809049.1722273922%40sss.pgh.pa.us>
Precedence: bulk

Heikki Linnakangas <hlinnaka@iki.fi> writes:
> Yeah I'm not worried about that at all. Also, the assert is made when 
> you have already released the spinlock; you are already out of the 
> critical section.

Not in the patch Andres posted.

			regards, tom lane