Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nhC6g-0001D9-Fw for pgsql-committers@arkaria.postgresql.org; Wed, 20 Apr 2022 15:19:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nhC6f-0005hc-EL for pgsql-committers@arkaria.postgresql.org; Wed, 20 Apr 2022 15:19:01 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nhC6f-0005hT-7h for pgsql-committers@lists.postgresql.org; Wed, 20 Apr 2022 15:19:01 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nhC6c-0002em-Ik for pgsql-committers@lists.postgresql.org; Wed, 20 Apr 2022 15:19:00 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 23KFIt4N2830045; Wed, 20 Apr 2022 11:18:55 -0400 From: Tom Lane To: Bruce Momjian cc: Daniel Gustafsson , Peter Eisentraut , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Fix some trailing whitespace in documentation files In-reply-to: References: <2021248.1650140817@sss.pgh.pa.us> <90abc132-ab5a-cbef-b330-8d58c24e4c6c@enterprisedb.com> <2548443.1650378244@sss.pgh.pa.us> <1A5D1665-86ED-4A96-A552-C7207CD5CF90@yesql.se> Comments: In-reply-to Bruce Momjian message dated "Tue, 19 Apr 2022 15:09:30 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2830043.1650467935.1@sss.pgh.pa.us> Date: Wed, 20 Apr 2022 11:18:55 -0400 Message-ID: <2830044.1650467935@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Bruce Momjian writes: > On Tue, Apr 19, 2022 at 08:57:23PM +0200, Daniel Gustafsson wrote: >> Mildly on-topic: Has the topic of a pgindent like process for docs been >> discussed at some point? The archives didn't turn up anything for me. > I don't remember any discussion of that. We have 'make check-tabs' for > SGML files, but that's about it. I've pushed a patch to remove the remaining trailing whitespace. I thought about adjusting 'make check-tabs' to know about that rule, but on the whole I'm inclined to remove it instead. The modern technology for this is "git diff --check" and variants of that, and I'm not sure why we should maintain a less-flexible alternative. (It'd be one less headache for the meson conversion, too.) regards, tom lane