Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKnf5-00008Z-0D for pgsql-hackers@arkaria.postgresql.org; Wed, 25 Jan 2023 21:50:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pKnf3-0007h0-H5 for pgsql-hackers@arkaria.postgresql.org; Wed, 25 Jan 2023 21:50:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKnf3-0007gr-7H for pgsql-hackers@lists.postgresql.org; Wed, 25 Jan 2023 21:50:29 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKnf0-0008Qx-UA for pgsql-hackers@postgresql.org; Wed, 25 Jan 2023 21:50:28 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 30PLoMc92848919; Wed, 25 Jan 2023 16:50:22 -0500 From: Tom Lane To: Nathan Bossart cc: Robert Haas , Michael Paquier , "pgsql-hackers@postgresql.org" Subject: Re: pgsql: Rename contrib module basic_archive to basic_wal_module In-reply-to: <20230125181750.GC1098626@nathanxps13> References: <20230125181750.GC1098626@nathanxps13> Comments: In-reply-to Nathan Bossart message dated "Wed, 25 Jan 2023 10:17:50 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2848917.1674683422.1@sss.pgh.pa.us> Date: Wed, 25 Jan 2023 16:50:22 -0500 Message-ID: <2848918.1674683422@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Nathan Bossart writes: > I wanted to merge basic_archive and basic_recovery because there's a decent > chunk of duplicated code. Would said code likely be duplicated into non-test uses of this feature? If so, maybe you ought to factor it out into a common location. I agree with Robert's point that basic_wal_module is a pretty content-free name. regards, tom lane