public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Thomas Munro <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: pgsql: Add file_extend_method=posix_fallocate,write_zeros.
Date: Thu, 12 Feb 2026 10:53:46 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>

Peter Eisentraut <[email protected]> writes:
> I suppose technically this is an ABI change since the size of 
> ConfigureNamesEnum is changed, but it seems this is irrelevant in 
> practice.  Could it be possible to ignore stuff like this without manual 
> intervention?

I am working on a bug report to libabigail, arguing that this should
not be reported as an ABI diff (at least not in --headersdir mode).
That's at best a long-term solution, but on the other hand it's
not every day that we add a new GUC to back branches.

There was upthread discussion about using a suppression file, but
that'd require some testing to ensure that it does what we want
and nothing more nor less.  (For instance, if suppressing
ConfigureNamesEnum resulted in no complaints about changes in
struct config_enum, that'd be very bad.)

Keep in mind also that libabigail seems to have some nasty blind
spots.  (I'm about to post something to pgsql-hackers about one that
I found last week.)

For the time being, I think we'd be well advised to treat the abidiff
reports as an experimental work-in-progress.  They might eventually
get to the level of trustworthiness that you seem to be envisioning,
but we're not there yet.

			regards, tom lane

view thread (10+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pgsql: Add file_extend_method=posix_fallocate,write_zeros.
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox