From: Tom Lane <tgl@sss.pgh.pa.us>
To: John Naylor <john.naylor@postgresql.org>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move gramparse.h to src/backend/parser
In-reply-to: <E1oYJbR-000FbR-LP@gemulon.postgresql.org>
References: <E1oYJbR-000FbR-LP@gemulon.postgresql.org>
Comments: In-reply-to John Naylor <john.naylor@postgresql.org>
	message dated "Wed, 14 Sep 2022 04:02:22 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2862806.1663184226.1@sss.pgh.pa.us>
Date: Wed, 14 Sep 2022 15:37:06 -0400
Message-ID: <2862807.1663184226@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2862807.1663184226%40sss.pgh.pa.us>
Precedence: bulk

John Naylor <john.naylor@postgresql.org> writes:
> Move gramparse.h to src/backend/parser

The cfbot is unhappy since this commit; some but not all tests fail with

[09:33:13.793] In file included from scan.c:39:
[09:33:13.793] ./gramparse.h:29:10: fatal error: 'gram.h' file not found
[09:33:13.794] #include "gram.h"
[09:33:13.794]          ^~~~~~~~
[09:33:13.839] In file included from parser.c:25:
[09:33:13.839] ./gramparse.h:29:10: fatal error: 'gram.h' file not found
[09:33:13.839] #include "gram.h"
[09:33:13.839]          ^~~~~~~~

What I think is happening is that it was a mistake to remove
parser/gram.h from the dependencies of backend/Makefile's
generated-headers target: that allows builds to proceed before
gram.h has necessarily been created.  The fact that it works
at all for anybody says that there's another dependency path
somewhere that causes bison to get run ... but, seemingly,
that doesn't always happen soon enough in a parallel build.

			regards, tom lane