Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1iF3QW-000133-5b
	for pgsql-committers@arkaria.postgresql.org; Mon, 30 Sep 2019 21:41:52 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1iF3QU-0008WV-VN
	for pgsql-committers@arkaria.postgresql.org; Mon, 30 Sep 2019 21:41:50 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1iF3QU-0008WK-LN
	for pgsql-committers@lists.postgresql.org; Mon, 30 Sep 2019 21:41:50 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1iF3QS-0005RL-F3
	for pgsql-committers@lists.postgresql.org; Mon, 30 Sep 2019 21:41:49 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x8ULfkn4028780;
	Mon, 30 Sep 2019 17:41:46 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Davis <pgsql@j-davis.com>
cc: Michael Paquier <michael@paquier.xyz>,
        pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add libpq parameter 'channel_binding'.
In-reply-to: <55c81610cba6bcc5289268ae46c686cabc439a0f.camel@j-davis.com>
References: <E1iCVWg-00057D-8U@gemulon.postgresql.org>
 <24857.1569775891@sss.pgh.pa.us> <20190929234733.GA2888@paquier.xyz>
 <20190930064539.GK2888@paquier.xyz> <20190930070826.GM2888@paquier.xyz>
 <55c81610cba6bcc5289268ae46c686cabc439a0f.camel@j-davis.com>
Comments: In-reply-to Jeff Davis <pgsql@j-davis.com>
	message dated "Mon, 30 Sep 2019 14:38:14 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <28778.1569879706.1@sss.pgh.pa.us>
Date: Mon, 30 Sep 2019 17:41:46 -0400
Message-ID: <28779.1569879706@sss.pgh.pa.us>
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Precedence: bulk

Jeff Davis <pgsql@j-davis.com> writes:
> Looks good to me, though I think you need to update the expected error
> message in the test you just added.

The test case did pass for me when I tried it on an old-openssl machine
a few hours ago.  I don't think this test has any way to exercise the
code path where the server has support and the client doesn't (or
vice versa).

			regards, tom lane