From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Andrew Dunstan <andrew@dunslane.net>,
        pgsql-committers@lists.postgresql.org,
        Sami Imseih <samimseih@gmail.com>
Subject: Re: pgsql: injection_points: Remove portions related to custom
 pgstats
In-reply-to: <E1vSSCn-003N0Z-2i@gemulon.postgresql.org>
References: <E1vSSCn-003N0Z-2i@gemulon.postgresql.org>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Mon, 08 Dec 2025 03:46:34 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2899651.1765167313.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sun, 07 Dec 2025 23:15:13 -0500
Message-ID: <2899652.1765167313@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2899652.1765167313%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> injection_points: Remove portions related to custom pgstats

BF member crake is unhappy with this, because it broke cross-version
update tests [1]:

pg_restore: while PROCESSING TOC:
pg_restore: from TOC entry 230; 1255 55098 FUNCTION injection_points_stats=
_drop() buildfarm
pg_restore: error: could not execute query: ERROR:  could not find functio=
n "injection_points_stats_drop" in file "/home/andrew/bf/root/saves.crake/=
HEAD/lib/postgresql/injection_points.so"
Command was: CREATE FUNCTION "public"."injection_points_stats_drop"() RETU=
RNS "void"
    LANGUAGE "c" STRICT
    AS '$libdir/injection_points', 'injection_points_stats_drop';

I think that this is really a bug in the Xversion-update test, because
I don't see why we'd be holding src/test/modules libraries to the
standard of can-be-upgraded-across-versions.  But maybe there's
something I'm missing?

			regards, tom lane

[1] https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=3Dcrake&=
dt=3D2025-12-08%2003%3A47%3A03&stg=3Dxversion-upgrade-REL_18_STABLE-HEAD