Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vSTJe-00FK1l-2O for pgsql-committers@arkaria.postgresql.org; Mon, 08 Dec 2025 04:57:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vSTJd-00EsiO-0s for pgsql-committers@arkaria.postgresql.org; Mon, 08 Dec 2025 04:57:41 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vSTJd-00EsiE-0D for pgsql-committers@lists.postgresql.org; Mon, 08 Dec 2025 04:57:41 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vSTJa-003hGx-34 for pgsql-committers@lists.postgresql.org; Mon, 08 Dec 2025 04:57:40 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 5B84vYtW2904428; Sun, 7 Dec 2025 23:57:34 -0500 From: Tom Lane To: Michael Paquier cc: Andrew Dunstan , pgsql-committers@lists.postgresql.org, Sami Imseih Subject: Re: pgsql: injection_points: Remove portions related to custom pgstats In-reply-to: References: <2899652.1765167313@sss.pgh.pa.us> Comments: In-reply-to Michael Paquier message dated "Mon, 08 Dec 2025 13:53:32 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2904426.1765169854.1@sss.pgh.pa.us> Date: Sun, 07 Dec 2025 23:57:34 -0500 Message-ID: <2904427.1765169854@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Michael Paquier writes: > On Sun, Dec 07, 2025 at 11:15:13PM -0500, Tom Lane wrote: >> I think that this is really a bug in the Xversion-update test, because >> I don't see why we'd be holding src/test/modules libraries to the >> standard of can-be-upgraded-across-versions. But maybe there's >> something I'm missing? > And I was wondering whether I should just plant more items in > AdjustUpgrade.pm, like in the attached. Nah, hold off till we have a discussion about whether the test is correct to expect compatibility. We can afford to have a couple of BF animals unhappy for a day or two while we come to a decision. regards, tom lane