Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from
 <pgsql-committers-owner+M65438=pgsql-committers-ark@postgresql.org>)
	id 1bx3wD-0006Hl-T2
	for pgsql-committers@arkaria.postgresql.org; Thu, 20 Oct 2016 03:22:37 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
	by malur.postgresql.org with smtp (Exim 4.84_2)
	(envelope-from
 <pgsql-committers-owner+M65438=pgsql-committers-ark@postgresql.org>)
	id 1bx3wD-0008Tu-Cj
	for pgsql-committers@arkaria.postgresql.org; Thu, 20 Oct 2016 03:22:37 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1bx3vy-0008Ff-Rd
	for pgsql-committers@postgresql.org; Thu, 20 Oct 2016 03:22:22 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1bx3vr-0007TO-Vf
	for pgsql-committers@postgresql.org; Thu, 20 Oct 2016 03:22:21 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id u9K3MDGu029392;
	Wed, 19 Oct 2016 23:22:13 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Sync our copy of the timezone library with IANA release
 tzcode20
In-reply-to: 
 <CAEepm=2kL=uhxPAEYtaSD4F_jojwz8JDtUt-hRqhq71G2FTUoQ@mail.gmail.com>
References: <E1bwzmk-0002YY-Vd@gemulon.postgresql.org>
 <CAEepm=2kL=uhxPAEYtaSD4F_jojwz8JDtUt-hRqhq71G2FTUoQ@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@enterprisedb.com>
	message dated "Thu, 20 Oct 2016 15:38:35 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <29390.1476933733.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 19 Oct 2016 23:22:13 -0400
Message-ID: <29391.1476933733@sss.pgh.pa.us>
X-Pg-Spam-Score: -2.2 (--)
List-Archive: <http://archives.postgresql.org/pgsql-committers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-committers.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@postgresql.org>
List-Post: <mailto:pgsql-committers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-committers>
List-Unsubscribe: 
 <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>
X-Mailing-List: pgsql-committers
Precedence: bulk
Sender: pgsql-committers-owner@postgresql.org

Thomas Munro <thomas.munro@enterprisedb.com> writes:
> On Thu, Oct 20, 2016 at 11:56 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Sync our copy of the timezone library with IANA release tzcode2016g.

> My compiler (Apple LLVM version 8.0.0 (clang-800.0.38)) doesn't like this:
> zic.c:427:53: error: implicit conversion from 'unsigned long long' to
> 'int' changes value from 18446744073709551615 to -1
> [-Werror,-Wconstant-conversion]
>                 int                     amax =3D nitems_max < SIZE_MAX ? =
nitems_max : SIZE_MAX;
>                                         ~~~~                             =
           ^~~~~~~~

Hmm ... I wonder what the IANA guys think they're doing here?
There are no platforms on which INT_MAX is more than SIZE_MAX.
I think we can just take this out.

(My RHEL6 compiler didn't object to this, but I can reproduce
it on Mac.)

			regards, tom lane


--=20
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers