Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJExD-0004Qp-He for pgsql-committers@arkaria.postgresql.org; Wed, 03 Aug 2022 14:02:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oJExC-0001Pu-EK for pgsql-committers@arkaria.postgresql.org; Wed, 03 Aug 2022 14:02:30 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJExC-0001Nk-7S for pgsql-committers@lists.postgresql.org; Wed, 03 Aug 2022 14:02:30 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJExA-0005Km-7j; Wed, 03 Aug 2022 14:02:29 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 273E2NHV2966704; Wed, 3 Aug 2022 10:02:23 -0400 From: Tom Lane To: Amit Kapila cc: Alvaro Herrera , Amit Kapila , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Add wait_for_subscription_sync for TAP tests. In-reply-to: References: <20220803104544.k2luy5hr2ugnhgr2@alvherre.pgsql> Comments: In-reply-to Amit Kapila message dated "Wed, 03 Aug 2022 16:55:37 +0530" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2966702.1659535343.1@sss.pgh.pa.us> Date: Wed, 03 Aug 2022 10:02:23 -0400 Message-ID: <2966703.1659535343@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Amit Kapila writes: > Yeah, that can happen for bug fixes but may not be a big problem as it > just avoids duplicate code. If you and others want we can back this > now or otherwise, we can do it later if we really see the difficulty > later. IMO we've seldom regretted back-patching testing infrastructure. We have regretted not doing so. regards, tom lane