From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add a regression test for allow_system_table_mods
In-reply-to: <1e7bb9a1-1104-907d-da62-857408d271ef@2ndquadrant.com>
References: <E1iacW7-0003h6-6U@gemulon.postgresql.org>
 <13656.1575041267@sss.pgh.pa.us>
 <315cfd3b-9d04-0ea4-76d8-1507c8bd9bb7@2ndquadrant.com>
 <15399.1575043746@sss.pgh.pa.us>
 <1e7bb9a1-1104-907d-da62-857408d271ef@2ndquadrant.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
	message dated "Mon, 02 Dec 2019 11:09:49 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <29778.1575299500.1@sss.pgh.pa.us>
Date: Mon, 02 Dec 2019 10:11:40 -0500
Message-ID: <29779.1575299500@sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 2019-11-29 17:09, Tom Lane wrote:
>> But using a different name isn't going to invalidate the test case,

> The test case is specifically testing tablespace names starting with "pg_":
>      -- reserved tablespace name
>      CREATE TABLESPACE pg_foo LOCATION '/no/such/location';
>      ERROR:  unacceptable tablespace name "pg_foo"
>      DETAIL:  The prefix "pg_" is reserved for system tablespaces.

Oh, I see.  But is testing that specific error case really worth
the trouble it's going to be to make this pass with or without 
-DENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS ?

One way would be to provide a variant expected-file, but that's not going
to be fun for future maintenance of the test script.  Another simple
answer is to crank up client_min_messages for this one test to hide the
WARNING, but you could conjure scenarios where that misses something
important.  (Of course, not running the test at all would also miss
any such issue.)

			regards, tom lane