Message-ID: <2985f969b292258ca007e9916839e2d07359ec15.camel@j-davis.com>
Subject: Re: pgsql: Fix search_path to a safe value during maintenance
 operations.
From: Jeff Davis <pgsql@j-davis.com>
To: Robert Haas <robertmhaas@gmail.com>, Noah Misch <noah@leadboat.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Jeff Davis <jdavis@postgresql.org>,
	pgsql-committers@lists.postgresql.org
Date: Mon, 12 Jun 2023 17:20:47 -0700
In-Reply-To: 
 <CA+TgmoaSJDJMqn-E5Xp=6Ojc_1C_MKnBPyctAOF1buBU=RPEiw@mail.gmail.com>
References: <E1q7j7Y-000z1H-Hr@gemulon.postgresql.org>
	 <89a415b86d5421941e4281ba5bf6288934078624.camel@j-davis.com>
	 <d20864b929ff769a0ebf772359719f05bb6982cd.camel@j-davis.com>
	 <573014.1686375211@sss.pgh.pa.us>
	 <20230612170510.GA201972@gust.leadboat.com>
	 <CA+TgmoaSJDJMqn-E5Xp=6Ojc_1C_MKnBPyctAOF1buBU=RPEiw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu1 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/2985f969b292258ca007e9916839e2d07359ec15.camel%40j-davis.com>
Precedence: bulk

On Mon, 2023-06-12 at 13:33 -0400, Robert Haas wrote:
> I wonder why this commit used pg_catalog, pg_temp rather than just
> the
> empty string, as AutoVacWorkerMain does.

I followed the rules here for "Writing SECURITY DEFINER Functions
Safely":

https://www.postgresql.org/docs/16/sql-createfunction.html

which suggests adding pg_temp at the end (otherwise it is searched
first by default).

It's not exactly like a SECURITY DEFINER function, but running a
maintenance command does switch to the table owner, so the risks are
similar.

I don't see a problem with the pg_temp schema in non-interactive
processes, because we trust the non-interactive processes.

Regards,
	Jeff Davis