Message-ID: <29e38dd3-0c48-4e65-b498-a78c5ce0ca9a@iki.fi>
Date: Wed, 10 Dec 2025 01:04:31 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: injection_points: Remove portions related to custom
 pgstats
To: Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>,
 pgsql-committers@lists.postgresql.org, Sami Imseih <samimseih@gmail.com>
References: <E1vSSCn-003N0Z-2i@gemulon.postgresql.org>
 <2899652.1765167313@sss.pgh.pa.us> <aTZZzFhQTtUKWGLm@paquier.xyz>
 <2904427.1765169854@sss.pgh.pa.us> <aTaPKpYufxut5Zs1@paquier.xyz>
 <d92f0eca-bb14-4b8c-9fb0-3b79635e1a64@iki.fi>
 <251242.1765302019@sss.pgh.pa.us>
 <ebfa8b0a-5858-4167-884c-499e70fce2cd@iki.fi> <aTimAYvtXnFojBaY@paquier.xyz>
 <302444.1765320564@sss.pgh.pa.us> <aTipJA1Y1zVSmH3H@paquier.xyz>
Content-Language: en-US
From: Heikki Linnakangas <hlinnaka@iki.fi>
In-Reply-To: <aTipJA1Y1zVSmH3H@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/29e38dd3-0c48-4e65-b498-a78c5ce0ca9a%40iki.fi>
Precedence: bulk

On 10/12/2025 00:56, Michael Paquier wrote:
> On Tue, Dec 09, 2025 at 05:49:24PM -0500, Tom Lane wrote:
>> They are updated when a new BF run is made for that branch, so
>> back-patching the DROP EXTENSION commands should do the trick.
> 
> Okay, good to know.  Let's do that then.
> 
> Encouraging a setup and a cleanup step seems like a good thing here,
> as people like copy-pasting contents when creating a module.  Should I
> just go ahead and make that happen?  The buildfarm breakage is still
> on me based on the commit maths.

Yes please. I'm also happy to help if you'd like. I'm eagerly waiting to 
see if the "Widen MultiXactOffset to 64 bits" commit caused any new 
cross-version pg_ugprade test failures.

> By the way, REGRESS in modules/nbtree/Makefile is missing
> nbtree_half_dead_pages..  meson.build has both tests.

That one is on me..

- Heikki