Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.2\))
Subject: Re: pgsql: Clean up role created in new subscription test.
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <284965.1680208176@sss.pgh.pa.us>
Date: Thu, 30 Mar 2023 22:53:03 +0200
Cc: Robert Haas <robertmhaas@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <2A3A15B2-FD71-4767-9A01-4C2C9264F960@yesql.se>
References: <E1phvk7-000VAH-7k@gemulon.postgresql.org>
 <CA+TgmoZ+K2OU0Ojs8_4SgqPWJJq7e0XiLd-uJGZ11R_WKF1URQ@mail.gmail.com>
 <267900.1680201870@sss.pgh.pa.us>
 <99112997-6732-42C7-989B-06406C911FE2@yesql.se>
 <284965.1680208176@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2A3A15B2-FD71-4767-9A01-4C2C9264F960%40yesql.se>
Precedence: bulk

> On 30 Mar 2023, at 22:29, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Daniel Gustafsson <daniel@yesql.se> writes:
>>> On 30 Mar 2023, at 20:44, Tom Lane <tgl@sss.pgh.pa.us> wrote:

>>> Another idea could be for pg_regress to enforce that "select =
count(*)
>>> from pg_roles" gives the same answer before and after the test run.
>=20
>> That wouldn't prevent the contents of pg_roles to have changed =
though, so there
>> is a (slim) false positive risk with that no?
>=20
> Well, we could do "select rolname from pg_roles order by 1" and
> actually compare the results of the two selects.  That might be
> advisable anyway, in order to produce a complaint with useful
> detail when there is something wrong.

I can see the value in doing something like this to keep us honest.

--
Daniel Gustafsson