Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q07jI-0005Qd-3N for pgsql-committers@arkaria.postgresql.org; Fri, 19 May 2023 21:33:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1q07jG-0001wp-VM for pgsql-committers@arkaria.postgresql.org; Fri, 19 May 2023 21:33:38 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q07jG-0001we-HW for pgsql-committers@lists.postgresql.org; Fri, 19 May 2023 21:33:38 +0000 Received: from meldrar.postgresql.org ([2a02:c0:301:0:ffff::31]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q07jD-000k1C-Q5 for pgsql-committers@lists.postgresql.org; Fri, 19 May 2023 21:33:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=postgresql.org; s=20171124; h=To:References:Message-Id: Content-Transfer-Encoding:Cc:Date:In-Reply-To:From:Subject:Mime-Version: Content-Type:Sender:Reply-To:Content-ID:Content-Description; bh=xjOoIoPqPZatVU/v94XdnfmhDnfG5tX2VjYzXrpwVjs=; b=CCaDQ1yh9xcKYcJ4SjunswrElg jPepuMqy3jj+CLpkQyxb7En4erzJ/q+oWyLF8RtDQjkNg6IL/ueSjjW22H7PirM6XN3KfXOt6p60f D1FYMgy5J7+6HZIHmBK7xUHPrI92cREUS0dFA4BlUaSu/MJ5Bt8laLEBg7u6vuuRLmcH3WYJV6IUe tQKhVF+m7S92tvCxNVMURanyd0XIpZL2fhTjDRsB/cDEjeYvZ2mWgD8SbXqS8WFrrkGXInhzi41Rq Wt/fJZXBua56Qqudk2t5QDz7tYiXNUnJtTZQ0ZxibDOPRafaEqvE1o6XCWQuU9AuIO5u6iSx7AYVs Jul6ymyw==; Received: from customer-89-255-232-193.stosn.net ([89.255.232.193] helo=smtpclient.apple) by meldrar.postgresql.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q07j8-001skz-Di; Fri, 19 May 2023 21:33:32 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.3\)) Subject: Re: pgsql: Refactor background psql TAP functions From: Daniel Gustafsson In-Reply-To: <0AFDFD10-178D-44FA-86A7-0909227119D5@postgresql.org> Date: Fri, 19 May 2023 23:33:28 +0200 Cc: Tom Lane , Peter Eisentraut , pgsql-committers@lists.postgresql.org Content-Transfer-Encoding: quoted-printable Message-Id: <2C39B660-D495-4540-B3CC-BD7BB9B37E57@postgresql.org> References: <34800305-E1E6-4194-8738-9977946DB12A@postgresql.org> <27BE2429-774C-46E6-8B0E-C024B83EC3B5@postgresql.org> <0AFDFD10-178D-44FA-86A7-0909227119D5@postgresql.org> To: Damir Belyalov X-Mailer: Apple Mail (2.3696.120.41.1.3) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 17 May 2023, at 14:38, Daniel Gustafsson = wrote: >=20 >> On 16 May 2023, at 21:43, Daniel Gustafsson = wrote: >>=20 >>> On 16 May 2023, at 21:04, Damir Belyalov = wrote: >>=20 >>> There is another perl module: AdjustUpgrade.pm that is not in = Makefile. Do we need it? >>=20 >> Yes, I think it should be installed too and skimming the linked = thread I see no >> mention of the omission being deliberate. I will take care of it. >=20 > The attached is the proposed fix, which will have to be backpatched to = v11 to > match the original commit. Unless there are reasons to treat this = module > differently from the others wrt installation I'll go ahead and fix it = in time > for beta1. After another round of thinking I opted out of pushing this, as the = module is so tied to pg_upgrade and the regress env it's use in installed pgxs is questionable. While I would prefer a 1:1 between the modules in the = source tree and the installed tree, this module doesn't seem like a great fit = for installation. -- Daniel Gustafsson