Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZpTG-0005j2-Do for pgsql-hackers@arkaria.postgresql.org; Thu, 31 Mar 2022 07:43:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nZpTF-0001Wi-9B for pgsql-hackers@arkaria.postgresql.org; Thu, 31 Mar 2022 07:43:53 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZpTE-0001SF-VS for pgsql-hackers@lists.postgresql.org; Thu, 31 Mar 2022 07:43:52 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZpTC-0000Z0-AR for pgsql-hackers@lists.postgresql.org; Thu, 31 Mar 2022 07:43:51 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 9E5AA5C015C; Thu, 31 Mar 2022 03:43:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 31 Mar 2022 03:43:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=aGweJj7+FxD8uV6shs8+dg93osIp3iNhQXI1zPHgk EM=; b=bgiuSebyx+3OVBW/HFWMOF4Y47zDw37P5jISUIk3MiQxsStKYcIOqPBaC dBQxlX+y9umN1H3qELBwKTFPyHrzycbs8djhQSiJOiSJFfRsFiu5k/4oZDysnC6+ 4prqJeXGOCbdzz9NUFoSmKGFE1pHuy+KBe+WAB35BiWwMqAdfxuksVVhyuzDd+i+ /q9z3r9SLTL+wFG82ub4FNu8TL2G00zTJqguIczoM8RdXyLbv2z5B74LLfQcld4a rxvyCgCTo3xKqvN6R3AJXR5qIY2tP2ZQx+tLdlMit45PsA72EI9ArJtPLQp2AwSE VytVyCyvArXb+GADDcaAuIE2imJPw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeifedguddujecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpefrvght vghrucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgvihhsvghnthhrrghuthesvghnth gvrhhprhhishgvuggsrdgtohhmqeenucggtffrrghtthgvrhhnpeefjeegheetuefhveev udelueeftdejteeiffetvdduhfdtieefgfeutedtveeggfenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpvghtvghrrdgvihhsvghnthhrrghu thesvghnthgvrhhprhhishgvuggsrdgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 31 Mar 2022 03:43:48 -0400 (EDT) Message-ID: <2b697df0-d294-2047-e91f-4b5da35bdb2c@enterprisedb.com> Date: Thu, 31 Mar 2022 09:43:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module. Content-Language: en-US To: Andres Freund , Tom Lane Cc: Robert Haas , Nathan Bossart , Andrew Dunstan , Thomas Munro , PostgreSQL Hackers , Magnus Hagander References: <20220330165450.3lruwky7eveddsvq@alap3.anarazel.de> <285252.1648671723@sss.pgh.pa.us> <20220330223531.GA134543@nathanxps13> <472639.1648684865@sss.pgh.pa.us> <485495.1648692468@sss.pgh.pa.us> <20220331021717.xusjlknpbs7szyv6@alap3.anarazel.de> <497188.1648699680@sss.pgh.pa.us> <20220331052500.eidoln5dcrhqza7b@alap3.anarazel.de> From: Peter Eisentraut In-Reply-To: <20220331052500.eidoln5dcrhqza7b@alap3.anarazel.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 31.03.22 07:25, Andres Freund wrote: > Looking at 8f3ec75de40 it seems we just assume unix sockets are available, we > don't have a version / feature test (win32.h just defines > HAVE_STRUCT_SOCKADDR_UN). I think you have to handle that dynamically at run time, a bit like IPv6: The build environment might provide symbols, structs, etc., but the kernel might return an error when you try to create a socket.