Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n1hrn-0007FQ-3Y for pgsql-committers@arkaria.postgresql.org; Mon, 27 Dec 2021 04:44:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1n1hrl-0001vN-V7 for pgsql-committers@arkaria.postgresql.org; Mon, 27 Dec 2021 04:44:09 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n1hrl-0001vE-OA for pgsql-committers@lists.postgresql.org; Mon, 27 Dec 2021 04:44:09 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n1hrj-0007wH-4j for pgsql-committers@lists.postgresql.org; Mon, 27 Dec 2021 04:44:08 +0000 Received: from [192.168.11.7] (p2638163-ipngn12701funabasi.chiba.ocn.ne.jp [180.59.132.163]) by oss.nttdata.com (Postfix) with ESMTPSA id 9F73D6010C; Mon, 27 Dec 2021 13:44:05 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.4 at oss.nttdata.com Message-ID: <2ccd9631-60ea-c220-5a2a-0e064bd406af@oss.nttdata.com> Date: Mon, 27 Dec 2021 13:44:05 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: pgsql: postgres_fdw: Allow postgres_fdw.application_name to include esc Content-Language: en-US To: Kyotaro Horiguchi Cc: fujii@postgresql.org, pgsql-committers@lists.postgresql.org References: <863b94a8-1cf2-237f-fa5e-53625748d192@oss.nttdata.com> <20211224.180006.2247635208768233073.horikyota.ntt@gmail.com> <20211224.184406.814784272581964942.horikyota.ntt@gmail.com> From: Fujii Masao In-Reply-To: <20211224.184406.814784272581964942.horikyota.ntt@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2021/12/24 18:44, Kyotaro Horiguchi wrote: > I once thought the same, but that change causes buildfarms *always* > truncate the resulting application name. I believe the base > application_name and database_name never grows further longer. So I'd > like to split the check to %a%u%% and %d%p. Yeah, probably it's better to split the test in that way. So I attached the patch doing that at the original thread [1] in pgsql-hackers. Let's discuss this there. [1] https://postgr.es/m/e7b61420-a97b-8246-77c4-a0d48fba5a45@oss.nttdata.com Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION