Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJ93D-0000Og-4Z for pgsql-committers@arkaria.postgresql.org; Thu, 26 Aug 2021 06:39:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mJ93B-0004J8-QM for pgsql-committers@arkaria.postgresql.org; Thu, 26 Aug 2021 06:39:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJ93A-0004Iy-Vt for pgsql-committers@lists.postgresql.org; Thu, 26 Aug 2021 06:39:45 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJ936-0002ns-MM for pgsql-committers@lists.postgresql.org; Thu, 26 Aug 2021 06:39:44 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id E1EE13200925; Thu, 26 Aug 2021 02:39:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 26 Aug 2021 02:39:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=6T/e9+byO8qVjnMAg5GQR4dR8n3U8i7U51gd7vA7K p0=; b=BzzOsgAzbYfOmVbymtDoHp+BE98zpqCMjezrgXU+tGIXL6fZkwyyvLL7Q lgUgclQm1FnfYwjeD4McUWaX/zsER3GSqwCh03Lt6sHM5Ldop5Z+x16uQcdnVPyl SVabroD4hq/j4S3HVlxlypVEauQ+vyg+6iSXi9t/RzEHIH2LmCKauslOqHp/sExP /RYDKOLHpyDcAiIbWaoAb/PijlVJD1Gdu4Yj1rD1HQw4+VituBPUbk0QjOQlM+70 sy1ApRWEMdAOUElPKKQXyPtpav9MFZVgr2cTq1GuMnM37AyxdUcdrketXKVlZcrJ 3VlNRCqmGt3WuJ4hlBOTSlG+g42+Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddruddutddguddutdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefuvfhfhffkffgfgggjtgfgsehtjeertddtfeehnecuhfhrohhmpefrvght vghrucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgvihhsvghnthhrrghuthesvghnth gvrhhprhhishgvuggsrdgtohhmqeenucggtffrrghtthgvrhhnpefhfeelfeeuveduvdff heejtdejjefglefhtddvffehledutedugeeffedtffffjeenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpvghtvghrrdgvihhsvghnthhrrghu thesvghnthgvrhhprhhishgvuggsrdgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 26 Aug 2021 02:39:33 -0400 (EDT) Subject: Re: pgsql: psql: Add test for query canceling To: Fabien COELHO , Tom Lane Cc: Daniel Gustafsson , pgsql-committers@lists.postgresql.org References: <5F16EBAA-30D3-4C0D-840C-C2FF2739E370@yesql.se> <1957503.1629485278@sss.pgh.pa.us> <9f46b102-da4d-8312-54f0-1f3bc10b453c@enterprisedb.com> <350197.1629824350@sss.pgh.pa.us> From: Peter Eisentraut Message-ID: <2e765fec-219a-378f-a035-f85c95ff3bff@enterprisedb.com> Date: Thu, 26 Aug 2021 08:39:31 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 25.08.21 07:37, Fabien COELHO wrote: > I finally came around to have a look at the patch. > > For the issue raised above, I can see that the file could be created but > not yet written, but as the patch waits for the file to be non zero, > ISTM that the probability of a torn write of a single integer by echo is > so remote that we could let it as that? > > Attached a version with the slurping in the loop anyway. It looks like this fixed it. Thanks all.