Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qAJVY-0008Sn-QS for pgsql-committers@arkaria.postgresql.org; Sat, 17 Jun 2023 00:09:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qAJVX-0007Xh-Ky for pgsql-committers@arkaria.postgresql.org; Sat, 17 Jun 2023 00:09:35 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qAJVX-0007WF-93 for pgsql-committers@lists.postgresql.org; Sat, 17 Jun 2023 00:09:35 +0000 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qAJVU-002cE7-7F for pgsql-committers@lists.postgresql.org; Sat, 17 Jun 2023 00:09:33 +0000 Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-6658b869cf2so1814547b3a.1 for ; Fri, 16 Jun 2023 17:09:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20221208.gappssmtp.com; s=20221208; t=1686960570; x=1689552570; h=mime-version:user-agent:references:in-reply-to:date:cc:to:from :subject:message-id:from:to:cc:subject:date:message-id:reply-to; bh=vNug7YVukyFXpuulRQjRGFK2ALrm3b39RK2AHlX7HOA=; b=vgZdv7KLJmQheeAg7dQgX548CEG1XHQFMYIoxxhS/784Jp+Lv+uT/wa4MkIKq1hG2g 62tPUeNI19WG6Dn1ZjYv9IRYwx4guYXXHtVWYVByiAMtwUXDeAzWQTKwBNx3huDojBg+ 5CTKsFKbmT6LO4HuPCpw1Tc191zsTCm2gMk4uKmkAdAGZQ18/yTyjyjzx5TjNH/WJ+hR TbmyuQ+HYU63AQeEXyNE6u/acZWMfx4AT7r5gYILjdHatcRItH27ffrmT39Atseq5m7Q rLDtZvjM1VijYgzNLwbS5g5hnq9Z49mh0Xd/crhA28/N5GW4mTFzPd4GdvxV2/6jkvEi 6Yyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686960570; x=1689552570; h=mime-version:user-agent:references:in-reply-to:date:cc:to:from :subject:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vNug7YVukyFXpuulRQjRGFK2ALrm3b39RK2AHlX7HOA=; b=l8SeqJPFOM/Q8jx4nCr64aMnqMlNF/6xJ97RghNgNNBeZJNiR92JHYpbecwt8bRv2R EvnM+nHze4J8C0vlBo6m54GzYNXw09rhOIL8dgiat/IVOybRX00CpkE/3Bsg8v/gOS/P pA0SC/INmZeUSbSENOMUD0W335Q/NMcKD1+/nJcYHhAtbJJtfMcTJ3IBlU19YvWok5Y8 reVJrR3AEnXUHFGb7vwxg248VY7wOt7holE97Sh2R43LaczQiHydLRxz65vDU5dbV1yg 02d+vc7xWrVo89cUK4fk6uj5A/h3Ron6gmQzs/izh5hzzpQHuIn6innsdvgv5zlP4xje Zbcg== X-Gm-Message-State: AC+VfDwHWiPqoa4HPVAt9fVnruwXIe3V2YhqSjx7Yd/PDE9JfEYjxdzK +7GzHb/hUWiDBH0Vf9QlYP906A== X-Google-Smtp-Source: ACHHUZ7p90AP7UB4ZyVIF9lyIOIozyjBKgsEYBJXhPU7qeqbs+rC9B1D/8sGZoWLLwSPE+q+sGyVMg== X-Received: by 2002:a17:902:ea05:b0:1b0:62e2:1f84 with SMTP id s5-20020a170902ea0500b001b062e21f84mr12433804plg.5.1686960570462; Fri, 16 Jun 2023 17:09:30 -0700 (PDT) Received: from jeff-laptop.lan (c-73-170-46-202.hsd1.ca.comcast.net. [73.170.46.202]) by smtp.gmail.com with ESMTPSA id y20-20020a170902b49400b001a980a23804sm16340122plr.4.2023.06.16.17.09.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jun 2023 17:09:29 -0700 (PDT) Message-ID: <2f4ec2a4e20966474aabce0035ddf939af47fffc.camel@j-davis.com> Subject: Re: pgsql: CREATE DATABASE: make LOCALE apply to all collation providers. From: Jeff Davis To: Tom Lane Cc: pgsql-committers@lists.postgresql.org Date: Fri, 16 Jun 2023 17:09:28 -0700 In-Reply-To: <2458565.1686953169@sss.pgh.pa.us> References: <770040bf2ca4c247b2c88837a3cb00d2798cdde6.camel@j-davis.com> <2458565.1686953169@sss.pgh.pa.us> Content-Type: multipart/mixed; boundary="=-Dd99IdzGgLOqwMjaLAjf" User-Agent: Evolution 3.44.4-0ubuntu1 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=-Dd99IdzGgLOqwMjaLAjf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2023-06-16 at 18:06 -0400, Tom Lane wrote: > You do not get to define that.=C2=A0 The reason we have buildfarm members > running tests this way is exactly to flush out tests that are unduly > collation-sensitive.=C2=A0 They will break in the field too. It looks like the actual problem is that, when pg_regress creates the database in --no-locale mode, it passes LC_COLLATE=3D'C' and LC_CTYPE=3D'C', instead of just LOCALE=3D'C'. Before my commit, the two were equivalent so it didn't matter, but afterwards it created an inconsistency that left daticulocale as cs-CZ. Patch attached. Regards, Jeff Davis --=-Dd99IdzGgLOqwMjaLAjf Content-Disposition: attachment; filename="v1-0001-pg_regress-for-no-locale-use-LOCALE-C.patch" Content-Type: text/x-patch; name="v1-0001-pg_regress-for-no-locale-use-LOCALE-C.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSAwOWNkY2MwNGZlNzljYTlkZjgwZDFmNDk5NzAxYmYzNDkwMmI3MDNmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWZmIERhdmlzIDxqZWZmQGotZGF2aXMuY29tPgpEYXRlOiBG cmksIDE2IEp1biAyMDIzIDE2OjQ2OjQxIC0wNzAwClN1YmplY3Q6IFtQQVRDSCB2MV0gcGdfcmVn cmVzczogZm9yIC0tbm8tbG9jYWxlLCB1c2UgTE9DQUxFPSdDJy4KCkluc3RlYWQgb2Ygc3BlY2lm eWluZyBMQ19DT0xMQVRFPSdDJyBhbmQgTENfQ1RZUEU9J0MnLCBzcGVjaWZ5CkxPQ0FMRT0nQycg d2hpY2ggd2lsbCBhbHNvIGFmZmVjdCBJQ1UuIFRoaXMgbWFrZXMgcGdfcmVncmVzcwpjb25zaXN0 ZW50IHdpdGggcmVjZW50IGNoYW5nZXMgdG8gaW5pdGRiIGluIGNvbW1pdCBhMTRlNzVlYjBiNi4K CkZpeGVzIGJ1aWxkZmFybSBmYWlsdXJlLgoKRGlzY3Vzc2lvbjogaHR0cHM6Ly9wb3N0Z3IuZXMv bS8yNDU4NTY1LjE2ODY5NTMxNjlAc3NzLnBnaC5wYS51cwotLS0KIHNyYy90ZXN0L3JlZ3Jlc3Mv cGdfcmVncmVzcy5jIHwgNCArKy0tCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAy IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3JlZ3Jlc3MvcGdfcmVncmVzcy5j IGIvc3JjL3Rlc3QvcmVncmVzcy9wZ19yZWdyZXNzLmMKaW5kZXggYTU0NmZjM2QzNC4uNjBkMzRh NDBiMiAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvcmVncmVzcy9wZ19yZWdyZXNzLmMKKysrIGIvc3Jj L3Rlc3QvcmVncmVzcy9wZ19yZWdyZXNzLmMKQEAgLTE5NzIsMTAgKzE5NzIsMTAgQEAgY3JlYXRl X2RhdGFiYXNlKGNvbnN0IGNoYXIgKmRibmFtZSkKIAkgKi8KIAlpZiAoZW5jb2RpbmcpCiAJCXBz cWxfYWRkX2NvbW1hbmQoYnVmLCAiQ1JFQVRFIERBVEFCQVNFIFwiJXNcIiBURU1QTEFURT10ZW1w bGF0ZTAgRU5DT0RJTkc9JyVzJyVzIiwgZGJuYW1lLCBlbmNvZGluZywKLQkJCQkJCSAobm9sb2Nh bGUpID8gIiBMQ19DT0xMQVRFPSdDJyBMQ19DVFlQRT0nQyciIDogIiIpOworCQkJCQkJIChub2xv Y2FsZSkgPyAiIExPQ0FMRT0nQyciIDogIiIpOwogCWVsc2UKIAkJcHNxbF9hZGRfY29tbWFuZChi dWYsICJDUkVBVEUgREFUQUJBU0UgXCIlc1wiIFRFTVBMQVRFPXRlbXBsYXRlMCVzIiwgZGJuYW1l LAotCQkJCQkJIChub2xvY2FsZSkgPyAiIExDX0NPTExBVEU9J0MnIExDX0NUWVBFPSdDJyIgOiAi Iik7CisJCQkJCQkgKG5vbG9jYWxlKSA/ICIgTE9DQUxFPSdDJyIgOiAiIik7CiAJcHNxbF9hZGRf Y29tbWFuZChidWYsCiAJCQkJCSAiQUxURVIgREFUQUJBU0UgXCIlc1wiIFNFVCBsY19tZXNzYWdl cyBUTyAnQyc7IgogCQkJCQkgIkFMVEVSIERBVEFCQVNFIFwiJXNcIiBTRVQgbGNfbW9uZXRhcnkg VE8gJ0MnOyIKLS0gCjIuMzQuMQoK --=-Dd99IdzGgLOqwMjaLAjf--