Message-ID: <2fa11ead-c923-470e-be29-232509317904@vondra.me>
Date: Wed, 16 Apr 2025 20:15:13 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: Add support for basic NUMA awareness
To: Jacob Champion <jacob.champion@enterprisedb.com>,
 Daniel Gustafsson <daniel@yesql.se>
Cc: Tomas Vondra <tomas.vondra@postgresql.org>,
 pgsql-committers@lists.postgresql.org
References: <E1u1tr8-003BbL-20@gemulon.postgresql.org>
 <CF6D7D7F-E1C4-45BE-9019-0F4B4BC7C135@yesql.se>
 <CAOYmi+=edeujaO9AQ-JxjkWyQgcVV3v7rv2E_Mvn1GP_WN6pOw@mail.gmail.com>
Content-Language: en-US
From: Tomas Vondra <tomas@vondra.me>
In-Reply-To: 
 <CAOYmi+=edeujaO9AQ-JxjkWyQgcVV3v7rv2E_Mvn1GP_WN6pOw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/2fa11ead-c923-470e-be29-232509317904%40vondra.me>
Precedence: bulk

On 4/16/25 18:34, Jacob Champion wrote:
> On Wed, Apr 16, 2025 at 9:30 AM Daniel Gustafsson <daniel@yesql.se> wrote:
>> It seems like this commit didn't run autoheader, which leaves a trivial diff in
>> pg_config.h.in carried over for future callers.  It doesn't change anuything
>> really as the HAVE_LIBNUMA macro isn't used, but for completeness sake we
>> should probably add it?
> 
> +1, I ran autoreconf during a rebase today and had to undo the new NUMA hunks :D
> 
> Your patch looks the same as what I'm carrying locally.
> 

Ah, I didn't notice the autoheader thing. The patch looks fine to me.
Daniel, do you intend to push it, or do you want me to do that?

regards

-- 
Tomas Vondra