Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGl3L-00006g-BL for pgsql-hackers@arkaria.postgresql.org; Wed, 27 Jul 2022 17:42:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oGl3K-0002x8-2i for pgsql-hackers@arkaria.postgresql.org; Wed, 27 Jul 2022 17:42:34 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGl3J-0002ua-P4 for pgsql-hackers@lists.postgresql.org; Wed, 27 Jul 2022 17:42:33 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGl3H-0004P8-Le for pgsql-hackers@lists.postgresql.org; Wed, 27 Jul 2022 17:42:33 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 26RHgRHt3017889; Wed, 27 Jul 2022 13:42:27 -0400 From: Tom Lane To: Robert Haas cc: Alvaro Herrera , PostgreSQL Hackers Subject: Re: pgsql: Remove the restriction that the relmap must be 512 bytes. In-reply-to: References: <20220727171939.6ixixqcjt5riil2o@alvherre.pgsql> Comments: In-reply-to Robert Haas message dated "Wed, 27 Jul 2022 13:38:36 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3017887.1658943747.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Wed, 27 Jul 2022 13:42:27 -0400 Message-ID: <3017888.1658943747@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Robert Haas writes: > On Wed, Jul 27, 2022 at 1:19 PM Alvaro Herrera = wrote: >> Another thing that seems to have happened here is that catversion ought >> to have been touched and wasn't. > Hmm, interesting. I didn't think about bumping catversion because I > didn't change anything in the catalogs. I did think about changing the > magic number for the file at one point, but unlike some of our other > constants, there's no indication that this one is intended to be used > as a version number. But in retrospect it would have been good to > change something somewhere. If you want me to bump catversion now, I > can. If you or someone else wants to do it, that's also fine. If there's a magic number, then I'd (a) change that and (b) adjust whatever comments led you to think you shouldn't. Bumping catversion is a good fallback choice when there's not any more-proximate version indicator, but here there is. regards, tom lane