Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGHC8-0001hE-1X for pgsql-committers@arkaria.postgresql.org; Mon, 03 Jul 2023 10:54:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qGHC6-0007Cg-Qb for pgsql-committers@arkaria.postgresql.org; Mon, 03 Jul 2023 10:54:10 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGHC6-0007CX-Iw for pgsql-committers@lists.postgresql.org; Mon, 03 Jul 2023 10:54:10 +0000 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qGHC3-001w21-5x for pgsql-committers@lists.postgresql.org; Mon, 03 Jul 2023 10:54:09 +0000 Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-98e011f45ffso399591366b.3 for ; Mon, 03 Jul 2023 03:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1688381645; x=1690973645; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eDSSnjQHQe0dC0IgNuFs6mdnbf2g5uyLPKG9tIdV+Ws=; b=bamtdelbC8eTTYAkcMWeTnZ5W7fy0dyJMPzEwtBvv89YuZKwVqPbq77KEvOPD0m4u7 GMVt7Iv41BfMmVmsi0q2/W6SCSz9Webl65tAFq/iTKfmjgY4L8f80f22VtH1x05m/oya UVlbTljY0y/3KUaao6P3fRzasvuAtsvBt6myWryTOZkvdayf7bT6iZrfegQRxU0c+3nF N83XU8v4dDusDIvVtgqx2i51cvXFZEQ+V0FzRYwh+pBr4Z3OWNNZ59jMy5D/0zTYEgOO 15PS/w8ocG8LGUrbUi/RMfCYDQ82LJpS0G++maQSDL5vAdHGXdgwFwm/k2M3BOvFd+QI Y3Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688381645; x=1690973645; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eDSSnjQHQe0dC0IgNuFs6mdnbf2g5uyLPKG9tIdV+Ws=; b=d86cbYs9++RRYtqsVAuBbVghO9WCXDoVvPYGX9nGpnJi0CnzPgKjot4adqW0ZAKFrf ZylgKwmyic6vFvqBmp7bOA0S1DXkct1m8Jx7tmW4yBtwTc9/xYGqq1QECILQ0sj3dxjZ EgVt8PyoOdflw/KYKsE4a1+K0A+ObFFzZVesDFpG/gn2lxrFYzDotQeLSrQ9t3pQP+DV IAeUn5UVmT94OdGuMteQnmfWkMKC9Xde/0eP/bM34ESGY+L0R3wsl7h6QcwjD00IWHsP R+rut95oDNtpDKFGZVeaAT0QeVMwzn+AQBjmqC+f1lrNcT1zCu5eiCZ6wXxqZFCPDwfa pMEA== X-Gm-Message-State: ABy/qLb/UZpemwBgtVMKcWeRPYrCO/f/D3u/WYcFXubmEFCV06BntEXK vevsh3QNNSXomkPhRS1wei7qkdxVMyzweLfmrSE= X-Google-Smtp-Source: APBJJlFu3HzdUxRW72KmHYOmFNy33Ao72iS2RE86J46zQV3aQUlvDTypyHcS5Jp/mlEfLZS2WcJ1BA== X-Received: by 2002:a17:906:af79:b0:970:71c:df58 with SMTP id os25-20020a170906af7900b00970071cdf58mr5082078ejb.42.1688381644823; Mon, 03 Jul 2023 03:54:04 -0700 (PDT) Received: from [10.137.0.17] (static-84-42-175-93.bb.vodafone.cz. [84.42.175.93]) by smtp.gmail.com with ESMTPSA id rl14-20020a170907216e00b00992ab0262c9sm5902186ejb.147.2023.07.03.03.54.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Jul 2023 03:54:04 -0700 (PDT) Message-ID: <30209687-c5f6-e659-67b7-a4972701c601@enterprisedb.com> Date: Mon, 3 Jul 2023 12:54:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: pgsql: Introduce bloom_filter_size for BRIN bloom opclass Content-Language: en-US To: Andrew Dunstan , Tom Lane , Michael Paquier Cc: Tomas Vondra , pgsql-committers@lists.postgresql.org References: <229983.1688344210@sss.pgh.pa.us> <74782c07-7e23-9f3b-a247-f468667b3dc0@dunslane.net> From: Tomas Vondra In-Reply-To: <74782c07-7e23-9f3b-a247-f468667b3dc0@dunslane.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 7/3/23 04:18, Andrew Dunstan wrote: > > On 2023-07-02 Su 20:30, Tom Lane wrote: >> Michael Paquier writes: >>> koel has failed its indent step after these commits. I am unsure >>> whether you need to fix this as it does not seem that we have a >>> consensus to automate that, just FYI. >> Well, *somebody* has to fix it, otherwise why did we set up the animal? >> But the impression I had was that a majority of committers want to >> start keeping the tree pgindent-clean. >> >> > > > I think we need to spell out expectations more clearly. Here's what I > said to Tomas in a private message: > > I think the expectation is that, while there might be cases where > you want to make some commits and then indent afterwards, so the > changes are clear, for most cases you should try to commit > pre-indented patches. > > But that's just my opinion. I think we need to spell it out more formally. > I've pushed a fix for the indentation issues caused by my commits (this one and the commit touching trigger.c). But I agree with Andrew it'd be good to spell out the expectations - perhaps it's spelled out somewhere deep in the pgindent, not sure. regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company