Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1iDGSe-0001qL-Js
	for pgsql-committers@arkaria.postgresql.org; Wed, 25 Sep 2019 23:12:40 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1iDGSd-0007Wg-52
	for pgsql-committers@arkaria.postgresql.org; Wed, 25 Sep 2019 23:12:39 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1iDGSc-0007WZ-UU
	for pgsql-committers@lists.postgresql.org; Wed, 25 Sep 2019 23:12:38 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1iDGSW-0001nO-9G
	for pgsql-committers@lists.postgresql.org; Wed, 25 Sep 2019 23:12:38 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x8PNCTO6030278;
	Wed, 25 Sep 2019 19:12:29 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Korotkov <a.korotkov@postgrespro.ru>
cc: Alexander Korotkov <akorotkov@postgresql.org>,
        pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: Implement jsonpath .datetime() method
In-reply-to: 
 <CAPpHfdteFKW6MLpXM4md99m55YAuXs0n9_P2wiTq_EmG09doUA@mail.gmail.com>
References: <E1iDDKf-0008VX-RT@gemulon.postgresql.org>
 <CAPpHfdteFKW6MLpXM4md99m55YAuXs0n9_P2wiTq_EmG09doUA@mail.gmail.com>
Comments: In-reply-to Alexander Korotkov <a.korotkov@postgrespro.ru>
	message dated "Thu, 26 Sep 2019 00:05:58 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <30276.1569453149.1@sss.pgh.pa.us>
Date: Wed, 25 Sep 2019 19:12:29 -0400
Message-ID: <30277.1569453149@sss.pgh.pa.us>
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Precedence: bulk

Alexander Korotkov <a.korotkov@postgrespro.ru> writes:
> I've noticed buildfarm is unhappy with my commits.

The proximate problem seems to be that compareItems() is insufficiently
careful to ensure that both values are non-null before passing them
off to datatype-specific code.  The code accidentally fails to crash
on 64-bit machines, but it's still giving garbage answers, I think.

			regards, tom lane