Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXRuL-0004QP-5k for pgsql-committers@arkaria.postgresql.org; Thu, 24 Mar 2022 18:10:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nXRuJ-0002pJ-Pu for pgsql-committers@arkaria.postgresql.org; Thu, 24 Mar 2022 18:09:59 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXRuJ-0002nE-Hx for pgsql-committers@lists.postgresql.org; Thu, 24 Mar 2022 18:09:59 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXRuD-0006r5-CJ for pgsql-committers@lists.postgresql.org; Thu, 24 Mar 2022 18:09:59 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 22OI9nCF3029089; Thu, 24 Mar 2022 14:09:49 -0400 From: Tom Lane To: Alvaro Herrera cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Change fastgetattr and heap_getattr to inline functions In-reply-to: References: Comments: In-reply-to Alvaro Herrera message dated "Thu, 24 Mar 2022 17:03:15 -0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3029087.1648145389.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Thu, 24 Mar 2022 14:09:49 -0400 Message-ID: <3029088.1648145389@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Alvaro Herrera writes: > Change fastgetattr and heap_getattr to inline functions wrasse isn't happy with this: ccache /opt/developerstudio12.6/bin/cc -m64 -Xa -v -O pg_resetwal.o -L../= ../../src/port -L../../../src/common -L/home/nm/sw/nopath/uuid-64/lib -L= /home/nm/sw/nopath/openldap-64/lib -Wl,--as-needed -Wl,-R'/home/nm/farm/st= udio64v12_6/HEAD/inst/lib' -lpgcommon -lpgport -lxslt -lxml2 -lpam -lssl = -lcrypto -lgssapi_krb5 -lz -lreadline -ltermcap -lnsl -lsocket -lm -o pg_= resetwal Undefined first referenced symbol in file nocachegetattr pg_resetwal.o ld: fatal: symbol referencing errors I believe you need to wrap those new inline functions in "#ifndef FRONTEND". regards, tom lane