From: Tom Lane <tgl@sss.pgh.pa.us>
To: Yasir <yasir.hussain.shah@gmail.com>
cc: =?UTF-8?B?Sm9zZWYgxaBpbcOhbmVr?= <josef.simanek@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Ignore Visual Studio's Temp Files While Working with PG on
 Windows
In-reply-to: 
 <CAA9OW9cevrcJQ79OjJrMmQ0u1HV=r=QcXitykiDv3cmh_muNbQ@mail.gmail.com>
References: 
 <CAA9OW9eFAn8FdG=vRvKE2F4PqLiiLAyS0RCHS0-SPDnPDGX8OQ@mail.gmail.com>
 <CAFp7QwrvDOin28Oyk7xQg4Wbw088dGS9uV57bec7OAhO4j8Zew@mail.gmail.com>
 <CAA9OW9cevrcJQ79OjJrMmQ0u1HV=r=QcXitykiDv3cmh_muNbQ@mail.gmail.com>
Comments: In-reply-to Yasir <yasir.hussain.shah@gmail.com>
	message dated "Sun, 19 May 2024 00:43:42 +0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3030318.1716064598.1@sss.pgh.pa.us>
Date: Sat, 18 May 2024 16:36:38 -0400
Message-ID: <3030319.1716064598@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3030319.1716064598%40sss.pgh.pa.us>
Precedence: bulk

Yasir <yasir.hussain.shah@gmail.com> writes:
> We can add it to "~/.config/git/ignore" as it will ignore globally on
> windows which we don't want. Also we don't have ".git/info/exclude" in PG
> project's so the best place left is projects's .gitignore. That's what was
> patched.

As Peter said, we're not going to do that.  The intention with
the project's .gitignore files is to ignore files that are
intentionally built by our "make" targets (and, hopefully, will be
removed by "make maintainer-clean").  Anything else that you want
git to ignore should be in a personal ignore list; especially
files that are platform-specific.  The fact that it's reasonable
to ignore ".vs" files when working with your toolset doesn't mean
that it's reasonable to ignore them when working on some other
platform.

If we used some other policy, we'd have tons of debates about
which files were reasonable to exclude.  For myself, for example,
I exclude "*~" (Emacs backup files) and "*.orig" (patch(1)
backup files) but those choices are very much dependent on the
set of tools I choose to use.  Other developers have other
personal exclusion lists.  If we tried to make the project's
files be the union of all those lists, we'd be at serious risk
of ignoring stuff we absolutely shouldn't ignore in some contexts.

			regards, tom lane