Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYdq4-0003E1-GD for pgsql-committers@arkaria.postgresql.org; Thu, 15 Sep 2022 01:38:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oYdq2-0005xZ-Eq for pgsql-committers@arkaria.postgresql.org; Thu, 15 Sep 2022 01:38:46 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYdq2-0005xQ-8B for pgsql-committers@lists.postgresql.org; Thu, 15 Sep 2022 01:38:46 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYdpy-0004Rd-TJ for pgsql-committers@lists.postgresql.org; Thu, 15 Sep 2022 01:38:45 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 28F1ce3i3043211; Wed, 14 Sep 2022 21:38:41 -0400 From: Tom Lane To: Andrew Dunstan cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Use the terminology "WAL file" not "log file" more consistently. In-reply-to: References: Comments: In-reply-to Andrew Dunstan message dated "Wed, 14 Sep 2022 21:19:41 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3043209.1663205920.1@sss.pgh.pa.us> Date: Wed, 14 Sep 2022 21:38:40 -0400 Message-ID: <3043210.1663205920@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andrew Dunstan writes: > The pg_upgrade part of this seems seriously awry (see buildfarm animal > crake). We can't assume that the upgrade source is using the new wording. Ugh. I'll look into a fix tomorrow --- but my first instinct is that pg_upgrade shouldn't be so dependent on the exact wording of pg_controldata output. regards, tom lane