Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJzxj-0004t6-FF for pgsql-committers@arkaria.postgresql.org; Tue, 15 Feb 2022 15:41:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nJzxi-00015B-Di for pgsql-committers@arkaria.postgresql.org; Tue, 15 Feb 2022 15:41:54 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJzxi-000152-6x for pgsql-committers@lists.postgresql.org; Tue, 15 Feb 2022 15:41:54 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJzxb-00010f-PX for pgsql-committers@lists.postgresql.org; Tue, 15 Feb 2022 15:41:53 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 21FFfig33047304; Tue, 15 Feb 2022 10:41:44 -0500 From: Tom Lane To: Peter Eisentraut cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Remove IS_AF_UNIX macro In-reply-to: References: Comments: In-reply-to Peter Eisentraut message dated "Tue, 15 Feb 2022 09:18:52 +0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3047302.1644939704.1@sss.pgh.pa.us> Date: Tue, 15 Feb 2022 10:41:44 -0500 Message-ID: <3047303.1644939704@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Peter Eisentraut writes: > Remove IS_AF_UNIX macro > The AF_UNIX macro was being used unprotected by HAVE_UNIX_SOCKETS, > apparently since 2008. I hadn't looked closely at this patch, but are you referring to this bit in ip.h? #ifdef HAVE_UNIX_SOCKETS #define IS_AF_UNIX(fam) ((fam) == AF_UNIX) #else #define IS_AF_UNIX(fam) (0) #endif That's by no means "unprotected": we will not try to reference AF_UNIX unless HAVE_UNIX_SOCKETS is set. I think this change will fail to break because we set HAVE_UNIX_SOCKETS everywhere, but I believe it was a mistake. We might as well just nuke all the HAVE_UNIX_SOCKETS conditional compilation if we let this stand. (Now, maybe we should indeed do that. I don't have much interest in the possibility that we'll worry about such platforms in future.) regards, tom lane