Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1njY9c-00030o-9l for pgsql-hackers@arkaria.postgresql.org; Wed, 27 Apr 2022 03:15:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1njY9b-0003px-6R for pgsql-hackers@arkaria.postgresql.org; Wed, 27 Apr 2022 03:15:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1njY9a-0003oN-SW for pgsql-hackers@lists.postgresql.org; Wed, 27 Apr 2022 03:15:46 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1njY9Y-0001u5-9a for pgsql-hackers@lists.postgresql.org; Wed, 27 Apr 2022 03:15:46 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 23R3Femd304866; Tue, 26 Apr 2022 23:15:40 -0400 From: Tom Lane To: Thomas Munro cc: Michael Paquier , Noah Misch , Jeff Davis , Postgres hackers Subject: Re: pgsql: Add contrib/pg_walinspect. In-reply-to: <298689.1651025716@sss.pgh.pa.us> References: <171769.1650950714@sss.pgh.pa.us> <287795.1651019129@sss.pgh.pa.us> <295868.1651024073@sss.pgh.pa.us> <298689.1651025716@sss.pgh.pa.us> Comments: In-reply-to Tom Lane message dated "Tue, 26 Apr 2022 22:15:16 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <304864.1651029340.1@sss.pgh.pa.us> Date: Tue, 26 Apr 2022 23:15:40 -0400 Message-ID: <304865.1651029340@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk I wrote: > Thomas Munro writes: >> BTW If you had your local change from debug.patch (upthread), that'd >> defeat the patch. I mean this: >> + if(!*errormsg) >> + *errormsg = "decode_queue_head is null"; > Oh! Okay, I'll retry without that. I've now done several runs with your patch and not seen the test failure. However, I think we ought to rethink this API a bit rather than just apply the patch as-is. Even if it were documented, relying on errormsg = NULL to mean something doesn't seem like a great plan. regards, tom lane