Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVRcL-0000k5-0C for pgsql-hackers@arkaria.postgresql.org; Tue, 06 Sep 2022 05:59:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oVRcJ-0004ik-T9 for pgsql-hackers@arkaria.postgresql.org; Tue, 06 Sep 2022 05:59:23 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVRb0-00084k-Fs for pgsql-hackers@lists.postgresql.org; Tue, 06 Sep 2022 05:58:02 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVRav-0001kq-Rn for pgsql-hackers@postgresql.org; Tue, 06 Sep 2022 05:58:02 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 2865vrpO3052114; Tue, 6 Sep 2022 01:57:53 -0400 From: Tom Lane To: Peter Eisentraut cc: Justin Pryzby , Beena Emerson , Andres Freund , pgsql-hackers@postgresql.org Subject: Re: [PATCH] Renumber confusing value for GUC_UNIT_BYTE In-reply-to: <5a943ffe-b07d-d99c-b96b-f4ed59c6f3ee@enterprisedb.com> References: <20220720145220.GJ12702@telsasoft.com> <5a943ffe-b07d-d99c-b96b-f4ed59c6f3ee@enterprisedb.com> Comments: In-reply-to Peter Eisentraut message dated "Tue, 06 Sep 2022 07:44:13 +0200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3052112.1662443873.1@sss.pgh.pa.us> Date: Tue, 06 Sep 2022 01:57:53 -0400 Message-ID: <3052113.1662443873@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Peter Eisentraut writes: > I think renumbering this makes sense. We could just leave the comment > as is if we don't come up with a better wording. +1, I see no need to change the comment. We just need to establish the precedent that values within the GUC_UNIT_MEMORY field can be chosen sequentially. regards, tom lane